Adjust particle visuals #23
Conversation
…tion emitters and player exhaust. # Conflicts: # src/spaced/spaced/game/hud.cpp
# Conflicts: # src/spaced/spaced/scenes/game.cpp
swagween
force-pushed
the
lana/particles
branch
from
56c43ae to
191b8a6
Compare
src/spaced/spaced/game/player.hpp
Outdated
| #include <spaced/game/controller.hpp> | ||
| #include <spaced/game/health.hpp> | ||
| #include <spaced/game/weapon.hpp> | ||
| #include <spaced/services/styles.hpp> |
There was a problem hiding this comment.
Move this include to the cpp file.
| StringMap<bave::Rgba> rgbas{}; | ||
| StringMap<ui::ButtonStyle> buttons{}; | ||
| StringMap<ui::ProgressBarStyle> progress_bars{}; | ||
| StringMap<ui::ProgressBarStyle> player{}; |
src/spaced/spaced/scenes/game.cpp
Outdated
|
|
||
| auto const& rgbas = get_services().get<Styles>().rgbas; | ||
| auto spawn = [this] { | ||
| auto spawn = [this, rgbas] { |
There was a problem hiding this comment.
Don't copy rgbas by value in the lambda, take it by reference instead; we know that the Styles reference will outlive m_enemy_spawner (because it's a service indirectly owned by Spaced) so it's safe. [this, &rgbas]
src/spaced/spaced/scenes/game.cpp
Outdated
| auto spawn = [this, rgbas] { | ||
| auto ret = std::make_unique<Creep>(get_services(), this); | ||
| ret->shape.tint = bave::yellow_v; | ||
| ret->shape.tint = random_in_range(-1.f, 1.f) < 0.f ? rgbas["orange"] : rgbas["milk"]; |
There was a problem hiding this comment.
Why not random_in_range(0, 1) == 0? Floating point randomness is more computationally expensive, and you just want a binary range (this or that), not a theoretically infinite range of floats.
src/spaced/spaced/scenes/home.cpp
Outdated
| #include <spaced/services/layout.hpp> | ||
| #include <spaced/services/resources.hpp> | ||
| #include <spaced/services/scene_switcher.hpp> | ||
| #include <spaced/services/styles.hpp> |
src/spaced/spaced/scenes/home.cpp
Outdated
| #include <spaced/util.hpp> | ||
|
|
||
| namespace spaced { | ||
| using bave::Rgba; |
src/spaced/spaced/scenes/home.cpp
Outdated
| void Home::on_loaded() { create_ui(); } | ||
|
|
||
| void Home::create_ui() { | ||
|
|
karnkaul
dismissed
their stale review
goddammit, pressed approve instead of request changes
karnkaul
left a comment
karnkaul
left a comment
There was a problem hiding this comment.
Refer to comments from the previous (mistakenly approved and then dismissed) review for requested changes.
need help with line 106 in
player.cpp