-
Couldn't load subscription status.
- Fork 24
field testing revealed various bugs #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenxianpeng
approved these changes
Oct 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me.
shenxianpeng
pushed a commit
that referenced
this pull request
Oct 21, 2021
* upload new demo image * Revert "upload new demo image" This reverts commit 1aff6c7. * update readme & upload new demo pic * avoids duplicated checks on commits to open PR * fix workflow from last commit * Revert "fix workflow from last commit" This reverts commit 778e10d. * rename py pkg; allow no clang-tidy & no event.json * pleasing pylint * various bug fixes * pleasing pylint * update README about `tidy-checks=-*` * increase indent in last change * increase indent again (I don't like mkdocs) * update docs * avoid nesting log groups * switch pylint to my check-python-sources action * trigger pylint action * Revert "switch pylint to my check-python-sources action" This reverts commit 1733c4f. * fix regressions from last update * break out parsing ignore option from main()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added this action to a project I'm helping develop, and I ran into some unforeseen problems. This resolves #29 , but I'll summarize the solutions here
.githubwas being ignored, but a sub-directory likesrc/.hiddenwas not being ignored.get_line_cnt_from_cols()to better support CRLF & LF line endings by opening the source file as a binary file. This might also address different encoded source files (anything that isn'tutf-8).:in the description. For example:std::arraywould previously cause a parsing error because I was usingstr.split(":")to parse the notification.This can now be run as a standalone CLI tool
For better usage as a CLI tool, I've renamed the python pkg from
python_actiontocpp_linter. Once installed, it can be executed anywhere by runningFurthermore, I changed some of the default values for the CLI args to check all files in the current working directory and disabling thread comments. These changes are overridden by the default values for options in the action.yml, so behaviorally, there are no changes to defaults when executing
cpp-linteras a github action.Also, I added
pyyamlback in as dependency when installing locally. This should not slow down the setup time aspyyamlis already installed in the docker image we use as an action, butpyyamlmay not be installed locally when used as a CLI tool.