Conversation
- [x] remove unused config - [x] update permissions for jobs that invoke reusable release-drafter workflows - [x] switch labeler workflow to use separate reusable workflow refs: - cpp-linter/.github#71 - cpp-linter/.github#74
WalkthroughThis pull request modifies GitHub workflow configuration files to update permissions management. The release-drafter configuration removes inherited settings, while workflow files add explicit permissions blocks to control repository access during workflow execution. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can customize the tone of the review comments and chat replies.Configure the |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/labeler.yml (1)
15-15: Consider pinning reusable workflow to a commit SHA instead of@main.Using a mutable ref can introduce unreviewed behavior changes; pinning improves reproducibility and supply-chain safety. Note that this pattern is used across multiple workflows in the repository (
stale.yml,release-drafter.yml,mkdocs-deploy.yml,pre-commit.yml, and others).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/labeler.yml at line 15, Replace the mutable ref on the reusable workflow import in the uses statement (the line currently `uses: cpp-linter/.github/.github/workflows/pr-labeler.yml@main`) with a pinned commit SHA; locate the uses entry in .github/workflows/labeler.yml (and mirror this change in other workflows like stale.yml, release-drafter.yml, mkdocs-deploy.yml, pre-commit.yml) and update `@main` to the specific commit SHA of the referenced repo/tag so the workflow is immutable and reproducible.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/labeler.yml:
- Line 15: Replace the mutable ref on the reusable workflow import in the uses
statement (the line currently `uses:
cpp-linter/.github/.github/workflows/pr-labeler.yml@main`) with a pinned commit
SHA; locate the uses entry in .github/workflows/labeler.yml (and mirror this
change in other workflows like stale.yml, release-drafter.yml,
mkdocs-deploy.yml, pre-commit.yml) and update `@main` to the specific commit SHA
of the referenced repo/tag so the workflow is immutable and reproducible.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: add34395-c7f8-405b-89c6-b945909b02af
📒 Files selected for processing (3)
.github/release-drafter.yml.github/workflows/labeler.yml.github/workflows/release-drafter.yml
💤 Files with no reviewable changes (1)
- .github/release-drafter.yml
refs:
Summary by CodeRabbit