feat: upgrade to rust edition 2024

[2bndy5]

Use of unsafe blocks (in tests only) is
ok due to use of cargo-nextest,
which creates a separate env for
each test (run in parallel).

Summary by CodeRabbit

• Refactor

  • Simplified control flow logic by consolidating nested conditions into more concise patterns throughout the codebase.
  • Reorganized imports for improved code consistency and readability.

• Chores

  • Updated Rust edition configuration to use workspace-managed versioning across all packages.

• Tests

  • Enhanced test infrastructure by adjusting environment variable handling in test setup procedures.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The PR updates workspace Rust edition configuration to "2024" by centralizing edition management in the workspace root Cargo.toml file. It simultaneously refactors source and test files with consistent import reordering, conditional logic simplification via pattern guards and if-let chains, and environment variable operations wrapped in unsafe blocks within test functions.

Changes

Cohort / File(s)	Summary
Edition Workspace Configuration Cargo.toml, bindings/node/Cargo.toml, bindings/python/Cargo.toml, cpp-linter/Cargo.toml	Added edition = "2024" in workspace root [workspace.package] section; updated package manifests to use edition.workspace = true instead of explicit edition declarations.
Logic Simplification and Import Reordering cpp-linter/src/clang_tools/clang_format.rs, cpp-linter/src/clang_tools/clang_tidy.rs, cpp-linter/src/clang_tools/mod.rs, cpp-linter/src/cli/mod.rs, cpp-linter/src/cli/structs.rs, cpp-linter/src/common_fs/file_filter.rs, cpp-linter/src/common_fs/mod.rs, cpp-linter/src/git.rs, cpp-linter/src/logger.rs, cpp-linter/src/rest_api/github/mod.rs, cpp-linter/src/rest_api/github/specific_api.rs, cpp-linter/src/rest_api/mod.rs, cpp-linter/src/run.rs	Reorganized imports within crate declarations for consistency; replaced nested if-let and if-else blocks with combined pattern guards and if-let chains (e.g., if let Some(x) = ... && let Some(y) = ...); minor assertion formatting adjustments in tests.
Test Environment Variable Safety cpp-linter/tests/comments.rs, cpp-linter/tests/paginated_changed_files.rs, cpp-linter/tests/reviews.rs	Wrapped environment variable mutations (env::set_var, env::remove_var) within unsafe blocks in test setup functions; conditional payload handling added for pull-request-only event logic.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~30 minutes

• Logic simplification across multiple files: Verify that pattern guard conversions (nested if-let to chained if-let-and guards) preserve original control flow and semantics; particularly in cpp-linter/src/clang_tools/clang_tidy.rs and cpp-linter/src/rest_api/mod.rs where conditional branches are consolidated.
• Test unsafe blocks: Confirm that wrapping env::set_var and env::remove_var in unsafe blocks is intentional and appropriate for the test harness; ensure no unguarded concurrent test interference.
• Import reordering consistency: Spot-check a few files to confirm import order changes follow a consistent alphabetical or logical grouping pattern and do not introduce unintended shadowing or visibility issues.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately describes the main change: upgrading the Rust edition to 2024. The changes across all Cargo.toml files and the refactored code patterns (like combined if-let guards) align with this edition upgrade goal.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 2024-edition

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6523512 and 242865b.

📒 Files selected for processing (20)

• Cargo.toml (1 hunks)
• bindings/node/Cargo.toml (1 hunks)
• bindings/python/Cargo.toml (1 hunks)
• cpp-linter/Cargo.toml (1 hunks)
• cpp-linter/src/clang_tools/clang_format.rs (3 hunks)
• cpp-linter/src/clang_tools/clang_tidy.rs (3 hunks)
• cpp-linter/src/clang_tools/mod.rs (5 hunks)
• cpp-linter/src/cli/mod.rs (2 hunks)
• cpp-linter/src/cli/structs.rs (1 hunks)
• cpp-linter/src/common_fs/file_filter.rs (2 hunks)
• cpp-linter/src/common_fs/mod.rs (3 hunks)
• cpp-linter/src/git.rs (4 hunks)
• cpp-linter/src/logger.rs (2 hunks)
• cpp-linter/src/rest_api/github/mod.rs (7 hunks)
• cpp-linter/src/rest_api/github/specific_api.rs (5 hunks)
• cpp-linter/src/rest_api/mod.rs (10 hunks)
• cpp-linter/src/run.rs (7 hunks)
• cpp-linter/tests/comments.rs (1 hunks)
• cpp-linter/tests/paginated_changed_files.rs (4 hunks)
• cpp-linter/tests/reviews.rs (1 hunks)

🧰 Additional context used

🧠 Learnings (7)

📓 Common learnings

Learnt from: 2bndy5
Repo: cpp-linter/cpp-linter-rs PR: 54
File: cpp-linter/src/rest_api/mod.rs:253-254
Timestamp: 2024-11-23T06:20:11.698Z
Learning: In `cpp-linter/src/rest_api/mod.rs`, it is safe to use `unwrap()` on `clang_versions.tidy_version` and `clang_versions.format_version` because they are guaranteed to be `Some` at that point in the code.

📚 Learning: 2025-11-04T06:50:10.870Z

Learnt from: 2bndy5
Repo: cpp-linter/cpp-linter-rs PR: 208
File: cpp-linter/src/clang_tools/mod.rs:60-115
Timestamp: 2025-11-04T06:50:10.870Z
Learning: In the cpp-linter-rs project, path validation (such as checking whether a path is a file or directory) should be performed in CLI parsing (cpp-linter/src/cli/structs.rs) rather than in the tool lookup logic (cpp-linter/src/clang_tools/mod.rs). This maintains proper separation of concerns.

Applied to files:

• cpp-linter/src/common_fs/file_filter.rs
• cpp-linter/src/cli/structs.rs
• cpp-linter/src/run.rs
• cpp-linter/tests/paginated_changed_files.rs
• cpp-linter/src/clang_tools/clang_tidy.rs
• cpp-linter/src/common_fs/mod.rs
• cpp-linter/src/git.rs
• bindings/node/Cargo.toml
• cpp-linter/src/cli/mod.rs
• cpp-linter/src/clang_tools/clang_format.rs
• cpp-linter/Cargo.toml
• cpp-linter/src/clang_tools/mod.rs
• cpp-linter/src/rest_api/github/mod.rs

📚 Learning: 2024-11-23T06:20:11.698Z

Learnt from: 2bndy5
Repo: cpp-linter/cpp-linter-rs PR: 54
File: cpp-linter/src/rest_api/mod.rs:253-254
Timestamp: 2024-11-23T06:20:11.698Z
Learning: In `cpp-linter/src/rest_api/mod.rs`, it is safe to use `unwrap()` on `clang_versions.tidy_version` and `clang_versions.format_version` because they are guaranteed to be `Some` at that point in the code.

Applied to files:

• cpp-linter/src/cli/structs.rs
• cpp-linter/src/run.rs
• Cargo.toml
• cpp-linter/src/clang_tools/mod.rs
• cpp-linter/src/rest_api/github/specific_api.rs
• cpp-linter/src/rest_api/github/mod.rs

📚 Learning: 2024-10-02T07:55:08.948Z

Learnt from: 2bndy5
Repo: cpp-linter/cpp-linter-rs PR: 52
File: cpp-linter/src/clang_tools/mod.rs:146-146
Timestamp: 2024-10-02T07:55:08.948Z
Learning: In the `cpp-linter` project, the function `capture_clang_tools_output` is only called in `cpp-linter/src/run.rs`, and there are no other calls to this function elsewhere in the codebase.

Applied to files:

• cpp-linter/src/run.rs
• cpp-linter/src/clang_tools/mod.rs

📚 Learning: 2024-11-23T14:10:31.760Z

Learnt from: 2bndy5
Repo: cpp-linter/cpp-linter-rs PR: 54
File: cpp-linter/src/clang_tools/mod.rs:149-159
Timestamp: 2024-11-23T14:10:31.760Z
Learning: Clang tools' `--version` output is consistent across all released versions, so adding extra error handling or unit tests for version extraction may be unnecessary. Tests are run after the clang tools are installed.

Applied to files:

• cpp-linter/src/run.rs
• cpp-linter/src/clang_tools/mod.rs

📚 Learning: 2025-01-21T09:56:32.771Z

Learnt from: 2bndy5
Repo: cpp-linter/cpp-linter-rs PR: 101
File: cpp-linter/src/clang_tools/clang_format.rs:155-161
Timestamp: 2025-01-21T09:56:32.771Z
Learning: In cpp-linter-rs, the XML output being parsed is generated programmatically by clang-format tool. The only failure case for XML parsing is when clang-format produces a blank XML document, in which case falling back to empty results (using unwrap_or) is the desired behavior.

Applied to files:

• cpp-linter/src/run.rs
• cpp-linter/src/common_fs/mod.rs
• Cargo.toml
• cpp-linter/src/clang_tools/clang_format.rs
• cpp-linter/Cargo.toml
• cpp-linter/src/clang_tools/mod.rs

📚 Learning: 2024-09-29T18:03:56.584Z

Learnt from: 2bndy5
Repo: cpp-linter/cpp-linter-rs PR: 50
File: .github/workflows/build-docs.yml:56-59
Timestamp: 2024-09-29T18:03:56.584Z
Learning: In the `cpp-linter` project, the `docs/` directory is a Python package defined by `pyproject.toml` and does not require a `setup.py` file.

Applied to files:

• bindings/node/Cargo.toml
• cpp-linter/Cargo.toml
• bindings/python/Cargo.toml

🧬 Code graph analysis (11)

cpp-linter/tests/reviews.rs (1)

cpp-linter/tests/common/mod.rs (1)

• mock_server (82-84)

cpp-linter/src/cli/structs.rs (1)

cpp-linter/src/common_fs/mod.rs (1)

• normalize_path (237-262)

cpp-linter/tests/paginated_changed_files.rs (1)

cpp-linter/src/rest_api/github/specific_api.rs (1)

• new (33-80)

cpp-linter/tests/comments.rs (2)

cpp-linter/src/main.rs (1)

• env (11-11)

cpp-linter/tests/common/mod.rs (1)

• mock_server (82-84)

cpp-linter/src/clang_tools/clang_tidy.rs (1)

cpp-linter/src/common_fs/mod.rs (1)

• normalize_path (237-262)

cpp-linter/src/common_fs/mod.rs (2)

cpp-linter/src/clang_tools/mod.rs (1)

• make_patch (368-390)

cpp-linter/tests/reviews.rs (1)

• summary_only (314-321)

cpp-linter/src/clang_tools/clang_format.rs (1)

cpp-linter/src/common_fs/mod.rs (1)

• get_line_count_from_offset (228-232)

cpp-linter/src/clang_tools/mod.rs (3)

cpp-linter/src/clang_tools/clang_format.rs (1)

• run_clang_format (84-186)

cpp-linter/src/clang_tools/clang_tidy.rs (2)

• run_clang_tidy (250-340)
• run_clang_tidy (449-459)

cpp-linter/src/cli/structs.rs (3)

• from_str (37-70)
• from_str (116-127)
• from_str (190-201)

cpp-linter/src/rest_api/github/specific_api.rs (2)

cpp-linter/src/clang_tools/clang_format.rs (1)

• summarize_style (56-67)

cpp-linter/src/rest_api/mod.rs (3)

• send_api_request (224-300)
• make_api_request (82-99)
• log_response (205-214)

cpp-linter/src/rest_api/github/mod.rs (1)

cpp-linter/src/git.rs (1)

• open_repo (28-30)

cpp-linter/src/rest_api/mod.rs (4)

cpp-linter/src/logger.rs (1)

• log (32-65)

cpp-linter/src/rest_api/github/mod.rs (2)

• get_list_of_changed_files (122-179)
• post_feedback (181-250)

cpp-linter/src/rest_api/github/specific_api.rs (1)

• new (33-80)

cpp-linter/src/cli/structs.rs (3)

• from_str (37-70)
• from_str (116-127)
• from_str (190-201)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)

• GitHub Check: linux (ubuntu-latest, armv7)
• GitHub Check: linux (ubuntu-latest, aarch64)
• GitHub Check: linux (ubuntu-latest, x86)
• GitHub Check: powerpc64-unknown-linux-gnu
• GitHub Check: aarch64-pc-windows-msvc
• GitHub Check: linux (ubuntu-latest, x86_64)
• GitHub Check: linux (ubuntu-latest, ppc64le)
• GitHub Check: build-py-binding
• GitHub Check: Build current binary
• GitHub Check: Build x86_64-apple-darwin
• GitHub Check: Build armv7-unknown-linux-gnueabihf
• GitHub Check: Build x86_64-unknown-linux-gnu
• GitHub Check: test (ubuntu-latest)
• GitHub Check: macos (macos-15, aarch64)
• GitHub Check: Build aarch64-unknown-linux-musl
• GitHub Check: macos (macos-15-intel, x86_64)
• GitHub Check: Build aarch64-unknown-linux-gnu
• GitHub Check: Build aarch64-pc-windows-msvc
• GitHub Check: Build x86_64-unknown-linux-musl
• GitHub Check: Build FreeBSD

🔇 Additional comments (37)

bindings/node/Cargo.toml (1)

8-8: LGTM!

The edition is now managed at the workspace level, which ensures consistency across all crates in the workspace.

bindings/python/Cargo.toml (1)

6-6: LGTM!

The edition is now managed at the workspace level, ensuring consistency across all crates.

cpp-linter/Cargo.toml (1)

8-8: LGTM!

The edition configuration now defers to the workspace, maintaining consistency with the upgrade to edition 2024.

cpp-linter/src/logger.rs (4)

5-5: Minor import reordering.

---

8-8: Minor import reordering.

---

96-96: Minor import reordering.

---

100-102: Environment variable mutation wrapped in unsafe block.

Per the PR objectives, env::set_var is now wrapped in unsafe blocks in tests. This aligns with Rust edition 2024's recognition that environment variable manipulation can cause data races. The use of cargo-nextest ensures test isolation.

cpp-linter/src/cli/mod.rs (2)

6-9: Minor import reordering.

---

457-457: Minor import reordering in tests.

cpp-linter/src/git.rs (5)

183-187: Using if-let chain syntax.

The combined condition using && with a let binding is a concise pattern for checking multiple conditions. This is well-supported in Rust edition 2024.

---

314-321: Test assertion formatting updated.

---

420-420: Minor import reordering.

---

425-425: Minor import reordering.

---

450-453: Environment variable mutation wrapped in unsafe block.

Consistent with the PR objectives, environment variable operations in tests are now wrapped in unsafe blocks. The comment clarifies the intent to avoid REST API usage in CI testing.

cpp-linter/src/common_fs/file_filter.rs (2)

1-1: Minor import reordering.

---

260-270: Test assertion formatting updated.

The multiline formatting improves readability without changing the test logic.

Cargo.toml (1)

16-16: Rust edition 2024 is stable and widely available. It was stabilized on February 20, 2025 (Rust 1.85.0) and can be used with stable toolchain. No action needed.

cpp-linter/src/cli/structs.rs (1)

3-4: LGTM! Import reordering is cosmetic.

The import order changes are purely cosmetic and do not affect functionality.

Also applies to: 10-10

cpp-linter/src/clang_tools/clang_format.rs (2)

18-18: LGTM! Import reordering is cosmetic.

The import order changes are purely cosmetic and do not affect functionality.

Also applies to: 190-190

---

74-78: LGTM! Effective use of edition 2024 if-let chains.

The refactoring from nested conditionals to a combined if-let chain with && is cleaner and leverages the edition 2024 feature appropriately.

cpp-linter/src/clang_tools/mod.rs (3)

14-14: LGTM! Import reordering is cosmetic.

The import order changes are purely cosmetic and do not affect functionality.

Also applies to: 25-25, 30-30

---

232-240: LGTM! Effective use of edition 2024 if-let chains.

The refactoring from nested conditionals to a combined if-let chain with && is cleaner and leverages the edition 2024 feature appropriately.

---

506-512: LGTM! Test assertion formatting improved.

The reformatted assertions using block syntax improve readability without changing behavior.

Also applies to: 519-525, 536-542

cpp-linter/tests/comments.rs (1)

66-82: LGTM! Unsafe blocks align with PR objectives.

The environment variable mutations are correctly wrapped in unsafe blocks. As noted in the PR description, this is acceptable in tests due to cargo-nextest creating separate environments for parallel test execution.

Also applies to: 88-90

cpp-linter/tests/reviews.rs (1)

79-90: LGTM! Unsafe blocks align with PR objectives.

The environment variable mutations are correctly wrapped in unsafe blocks. As noted in the PR description, this is acceptable in tests due to cargo-nextest creating separate environments for parallel test execution.

Also applies to: 96-98

cpp-linter/src/clang_tools/clang_tidy.rs (2)

21-21: LGTM! Import reordering is cosmetic.

The import order changes are purely cosmetic and do not affect functionality.

Also applies to: 359-359

---

208-212: LGTM! Effective use of edition 2024 if-let chains.

The refactoring from nested conditionals to combined if-let chains with && is cleaner and leverages the edition 2024 feature appropriately. Both cases correctly combine pattern matching with additional conditions.

Also applies to: 217-220

cpp-linter/src/common_fs/mod.rs (2)

12-12: LGTM! Import reordering is cosmetic.

The import order changes are purely cosmetic and do not affect functionality.

Also applies to: 269-269

---

150-155: LGTM! Effective use of edition 2024 if-let chains.

The refactoring from nested conditionals to a combined if-let chain with && is cleaner and leverages the edition 2024 feature appropriately.

cpp-linter/src/run.rs (2)

13-13: LGTM! Import reordering is cosmetic.

The import order changes are purely cosmetic and do not affect functionality.

Also applies to: 15-15, 23-23

---

165-167: LGTM! Unsafe blocks align with PR objectives.

The environment variable mutations are correctly wrapped in unsafe blocks across all tests. As noted in the PR description, this is acceptable in tests due to cargo-nextest creating separate environments for parallel test execution.

Also applies to: 182-184, 191-193, 207-209, 222-225, 240-242, 257-259

cpp-linter/tests/paginated_changed_files.rs (2)

43-64: Proper use of unsafe for environment variable mutations in tests.

The environment variable mutations are correctly wrapped in an unsafe block as required by Rust edition 2024. Based on the PR description, cargo-nextest provides test isolation, making this acceptable for test code.

---

78-80: LGTM!

Consistent with the proper pattern of wrapping env var mutations in unsafe blocks.

cpp-linter/src/rest_api/github/specific_api.rs (1)

496-534: Excellent use of if-let chains to reduce nesting.

The refactoring leverages Rust edition 2024's if-let chains to simplify the conditional logic for dismissing outdated reviews. The flow is now more concise while maintaining the same behavior:

1. Verify review body exists, matches the marker, and is in a dismissible state
2. Construct dismiss URL and API request
3. Send the dismissal request

The logic is correct and more readable than the previous nested structure.

cpp-linter/src/rest_api/github/mod.rs (1)

330-347: Proper use of unsafe for environment variable mutations in tests.

All test environment variable mutations are correctly wrapped in unsafe blocks as required by Rust edition 2024. The test isolation provided by cargo-nextest (as noted in the PR description) makes this acceptable for test code.

Also applies to: 392-394, 405-407, 415-417, 428-430

cpp-linter/src/rest_api/mod.rs (2)

183-203: Improved pagination logic with if-let chains.

The refactoring of try_next_page leverages edition 2024's if-let chains to simplify the control flow. The logic now has better error handling with dedicated debug logs for both parsing failures and malformed link headers, making debugging easier.

The implementation correctly extracts the next page URL from the "link" header while maintaining the same behavior as before.

---

317-326: Clean refactoring using if-let chains.

The use of if-let chains in make_format_comment simplifies the nested conditionals into a single guard clause. This makes it immediately clear that all three conditions (format advice exists, has replacements, has remaining space) must be satisfied before processing the note.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 98.43750% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.79%. Comparing base (6523512) to head (242865b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
cpp-linter/src/rest_api/github/specific_api.rs	92.68%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   96.53%   96.79%   +0.26%     
==========================================
  Files          14       14              
  Lines        2999     3027      +28     
==========================================
+ Hits         2895     2930      +35     
+ Misses        104       97       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.