fix: rename temp downloaded file to given cache path

[2bndy5]

resolves #330

This simply keeps the downloaded temp file in the same directory as the destination of the downloaded file. When download is done, the file is renamed to the specified file name.

This also removes the tempfile dependency from production code. It is still used heavily in tests.

Summary by CodeRabbit

• Bug Fixes

  • Improved error handling for download operations with clearer, contextual messages when temporary file or filesystem operations fail.

• Breaking Changes

  • The shape of download error reporting was changed; integrations that inspect specific download error variants may need updates.

• Chores

  • Test/dev setup updated (added a dev dependency for temporary-file utilities) and CI triggers expanded to include installer-related files and manifests.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e5bb8a87-375b-4eb5-b9be-bc2641bf9636

📥 Commits

Reviewing files that changed from the base of the PR and between 636682e and 94a806c.

📒 Files selected for processing (2)

• .github/workflows/run-dev-tests.yml
• clang-installer/src/downloader/mod.rs

🚧 Files skipped from review as they are similar to previous changes (1)

• clang-installer/src/downloader/mod.rs

---

Walkthrough

Refactors clang-installer download flow to write to a deterministic temp path and atomically persist via fs::rename while mapping IO errors to a new DownloadError::TempFile variant; adds tempfile to dev-dependencies and expands CI workflow path filters to include clang-installer/** and manifest files.

Changes

Temporary file handling refactor

Layer / File(s)	Summary
Error type contract clang-installer/src/downloader/mod.rs	DownloadError replaces TempFilePersistence(#[from] tempfile::PersistError) with TempFile(&'static str, #[source] std::io::Error).
Download file creation and finalization clang-installer/src/downloader/mod.rs	Switches from tempfile::NamedTempFile to opening cache_path.with_extension("tmp") with fs::OpenOptions, writing chunks, setting modified time, dropping the handle, and persisting via fs::rename, mapping failures to the new error variant.
Development dependency for tests clang-installer/Cargo.toml	Adds tempfile to [dev-dependencies] for test fixtures that require temporary files.

CI workflow trigger update

Layer / File(s)	Summary
Workflow path filters .github/workflows/run-dev-tests.yml	on.push.paths and on.pull_request.paths now include clang-installer/**, Cargo.toml, Cargo.lock, and the workflow file.

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Possibly related PRs:
  • cpp-linter/cpp-linter-rs#279: touches clang-installer/src/downloader/mod.rs with related temp-file/persist refactoring.

Suggested labels: rust

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: refactoring temp file handling to rename temp files to the cache path instead of using cross-device atomic rename.
Linked Issues check	✅ Passed	The code changes successfully implement the solution from issue #330: temp file is now created in the same directory as cache path and renamed after download, avoiding cross-device rename failures.
Out of Scope Changes check	✅ Passed	All changes are directly related to issue #330: removing tempfile from production code, implementing deterministic temp path in cache directory, and updating CI workflow to test the installer crate.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch no-atomic-rename

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.91%. Comparing base (8e2fcad) to head (94a806c).

Files with missing lines	Patch %	Lines
clang-installer/src/downloader/mod.rs	84.61%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
- Coverage   90.94%   90.91%   -0.04%     
==========================================
  Files          22       22              
  Lines        3368     3378      +10     
==========================================
+ Hits         3063     3071       +8     
- Misses        305      307       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.