add close PsychPortAudio close to clean up #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Remi-Gau
reviewed
May 17, 2020
|
|
||
| % Close Psychportaudio if open | ||
| if PsychPortAudio('GetOpenDeviceCount') ~= 0 | ||
| PsychPortAudio('Close'); |
Contributor
There was a problem hiding this comment.
Actually I might have merged too quickly.
Do you think that the if is necessary?
Can we just not do a psychportaudio(close)
Collaborator
Author
There was a problem hiding this comment.
Yes, it should work anyway. I used that because biased by macs behavior where if you close things that were not opened it crashes badly, e.g. using sca or close all at the beginning of a ptb experiment. But I could be wrong in the case of psychportaudio.
Contributor
There was a problem hiding this comment.
OK let's keep it that way then. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just added a couple of line that checks if an audio device was opened and therefore needs to be close. Have you had in mind something like this in #7 ?