Skip to content

add close PsychPortAudio close to clean up #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2020
Merged

add close PsychPortAudio close to clean up #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bea1243
Merge pull request #1 from cpp-lln-lab/master
marcobarilari May 14, 2020
f6fd378
add a line to close Psychportaudio if open
marcobarilari May 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cleanUp.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@
% Screen Close All
sca;

% Close Psychportaudio if open
if PsychPortAudio('GetOpenDeviceCount') ~= 0
PsychPortAudio('Close');
Copy link
Contributor

@Remi-Gau Remi-Gau May 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I might have merged too quickly.

Do you think that the if is necessary?

Can we just not do a psychportaudio(close)

Copy link
Collaborator Author

@marcobarilari marcobarilari May 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should work anyway. I used that because biased by macs behavior where if you close things that were not opened it crashes badly, e.g. using sca or close all at the beginning of a ptb experiment. But I could be wrong in the case of psychportaudio.

Copy link
Contributor

@Remi-Gau Remi-Gau May 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK let's keep it that way then. :-)

end

if ~ismac
% remove PsychDebugWindowConfiguration
clear Screen
Expand Down