-
Notifications
You must be signed in to change notification settings - Fork 1
add functions to deal with pre-analysis steps from CPP_SPM #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add functions to deal with pre-analysis steps from CPP_SPM #2
Conversation
Remi-Gau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the README in the other PR.
Once this is accepted, we remove those functions them from the CPP_SPM repo, correct?
Remi-Gau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: do we want to move the batch setting functions to this repo as we might also need them for CPP_SPM (especially to zip the derivatives or to convert the 3D beta images into 4D ones).
For the latter I had never done that in the past but I have seen several people in the lab using that strategy, so I am happy to make their life easier.
So the idea would be that the CPP_sourceMRI folder would have most the demos and the "workflows" to work on a source dataset, and then anything that is not purely source specific, we put in CPP_SPM?
|
Other question: do we want to use SPM batches for zipping (and unzipping)? I know that not everything has to go through a freaking SPM batch, but it makes for a "nice" way to create tests and ensure that things are properly formatted before we run them (ideally prevents to have error at run time). Also this can help create log file to track what was done when. |
|
For the continuous integration: I have been struggling to create a test with SPM and moxunit. So for the tests on CPP_SPM I still run the tests via travis but I think that I now "know" enough to maybe finish that transition. Just to let you know why your tests are failing in CI. If you want run them you might have to look into the travis config of CPP_SPM: https://github.com/cpp-lln-lab/CPP_SPM/blob/1b890f38257abcc603ed2ef78154a327640134ca/.travis.yml#L51 |
I am open to other solutions that might fit better with our purpose. I chose SPM cause it was the "faster" to implement it |
Good questions, I have no idea about what could be ideal. Hard to figure out at this stage without a first experience at those "later" stages. |
Co-authored-by: Remi Gau <remi_gau@hotmail.com>
OK let's keep this one in mind for later. :-) |
other possibility: have a separate repo that only contains the code to and we add as a submodule where needed. pro:
con:
|
Co-authored-by: marcobarilari <38101692+marcobarilari@users.noreply.github.com>
|
merging this because I need to use it. :-) |
No description provided.