Skip to content

Conversation

@marcobarilari
Copy link
Contributor

@marcobarilari marcobarilari commented Mar 8, 2021

@marcobarilari marcobarilari requested a review from Remi-Gau March 8, 2021 14:43
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #6 (9b31ac9) into master (f18c835) will increase coverage by 38.09%.
The diff coverage is 38.09%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #6       +/-   ##
===========================================
+ Coverage        0   38.09%   +38.09%     
===========================================
  Files           0        6        +6     
  Lines           0       84       +84     
===========================================
+ Hits            0       32       +32     
- Misses          0       52       +52     
Flag Coverage Δ
unittests 38.09% <38.09%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/bidsGZipRawFolder.m 0.00% <0.00%> (ø)
src/convert3Dto4D.m 0.00% <0.00%> (ø)
src/setDefaultFields.m 83.33% <83.33%> (ø)
src/batches/setBatchGZip.m 100.00% <100.00%> (ø)
src/defaults/checkOptionsSource.m 100.00% <100.00%> (ø)
src/printBatchName.m 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9848445...b2d36a4. Read the comment docs.

@marcobarilari
Copy link
Contributor Author

at the moment we decided that we would like to havesourceMRIto work as a stand-alone tool so we keep code that is in common withCPP_SPM`

Copy link
Contributor

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with me

Merge at will

@marcobarilari marcobarilari merged commit 6ba2d10 into cpp-lln-lab:master Mar 8, 2021
@marcobarilari marcobarilari deleted the marco_springCleaning branch March 8, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants