Check of the inputs in bidsSTC gives odd results

[marcobarilari]

Describe your problem in detail

When the maximum value in sliceOrder correspond to TA, the check on the line below throws an error

https://github.com/cpp-lln-lab/CPP_SPM/blob/0d9684007d5292c76b45cd892d7ee3a652995e40/src/batches/setBatchSTC.m#L60

Describe what outcome you expected

given that the values are equal (e.g. max(sliceOrder) = 2.4359 and TA = 2.4359) the check any(sliceOrder > TA) should be ok

Describe what you got instead

I get the error as any(sliceOrder > TA) is true, possible problem may rely on being floating-point values

[Remi-Gau]

If you want to move forward despite this I am tempted to tell you to comment out the part of the if statement that is causing trouble.

Open a PR to "hack" this but we will leave the issue open so that we know this requires a proper fix.

Does that sound good?

[marcobarilari]

Yes definitely, commenting that part is what I did.

[CerenB]

to report back, I've re-ran pre-processing with the updated bidsSTC.m function, and all the results seem to be the same.

[Remi-Gau]

what was your design? block design?

[CerenB]

oh that is a good guess, as we discussed before in a block design, not much would change. I will report back with the FFT analysis which was not a block nor event related :D