Skip to content

Conversation

@Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Mar 9, 2021

fixes #299
fixes #256
fixes #290
fixes #275

This affects a LOT of things!!!! Sorry.


Main changes

  • modify the way groups are handled

opt.subjects is now updated if user asks for some opt.groups, the groups variable is removed.

  • simplify workflows and batch to remove any loop over groups
  • update tests

Other changes

  • refactor test and improve test code base
  • rename variable subID by subLabel

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Mar 9, 2021

Will most likely merge this one before all the other things we have pending as this is likely going to create a lot of merge conflicts.

Remi-Gau added 2 commits March 9, 2021 11:31
- refactor
- rename test functions
- lint
- add copyright
@Remi-Gau Remi-Gau linked an issue Mar 9, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #314 (a92a480) into dev (c3a76e0) will increase coverage by 0.87%.
The diff coverage is 33.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #314      +/-   ##
==========================================
+ Coverage   63.91%   64.78%   +0.87%     
==========================================
  Files         104      104              
  Lines        1649     1616      -33     
==========================================
- Hits         1054     1047       -7     
+ Misses        595      569      -26     
Impacted Files Coverage Δ
src/QA/anatomicalQA.m 0.00% <0.00%> (ø)
src/QA/functionalQA.m 0.00% <0.00%> (ø)
src/batches/setBatchCoregistrationFmap.m 0.00% <0.00%> (ø)
src/getFuncVoxelDims.m 100.00% <ø> (ø)
src/getInfo.m 94.73% <ø> (ø)
src/getPrefix.m 100.00% <ø> (ø)
src/reports/copyFigures.m 0.00% <0.00%> (ø)
src/utils/printProcessingSubject.m 100.00% <ø> (ø)
src/workflows/bidsConcatBetaTmaps.m 0.00% <0.00%> (ø)
src/workflows/bidsCreateVDM.m 0.00% <0.00%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3a76e0...a92a480. Read the comment docs.

@Remi-Gau Remi-Gau merged commit 3a4cfd8 into cpp-lln-lab:dev Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant