Skip to content

Conversation

@Remi-Gau
Copy link
Contributor

fixes #1052
closes #1047

@Remi-Gau Remi-Gau changed the title [FIX] Fix the way the voxel size is conputed [FIX] Fix the way the voxel size is computed Jun 19, 2023
@Remi-Gau Remi-Gau marked this pull request as ready for review June 19, 2023 09:52
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Attention: Patch coverage is 7.14286% with 26 lines in your changes missing coverage. Please review.

Project coverage is 79.62%. Comparing base (7d52979) to head (d47efa0).
Report is 187 commits behind head on main.

Files with missing lines Patch % Lines
src/workflows/bidsCheckVoxelSize.m 0.00% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1053      +/-   ##
==========================================
- Coverage   79.95%   79.62%   -0.33%     
==========================================
  Files         244      246       +2     
  Lines        6655     6691      +36     
  Branches       40       40              
==========================================
+ Hits         5321     5328       +7     
- Misses       1318     1347      +29     
  Partials       16       16              
Flag Coverage Δ
cli 38.99% <ø> (ø)
macos-latest_matlab-R2022b 80.87% <7.14%> (-0.35%) ⬇️
octave 76.78% <7.14%> (-0.34%) ⬇️
ubuntu-latest_matlab-R2022b 81.04% <7.14%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Remi-Gau Remi-Gau merged commit 07254b7 into cpp-lln-lab:main Jun 19, 2023
@Remi-Gau Remi-Gau deleted the fix/voxel_size branch June 19, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

voxDim does not account for zoom check consistency of voxel size of images to be normalized during preprocessing

1 participant