Skip to content

Conversation

@Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Oct 31, 2020

Before merging

  • update version.txt
  • make sure all tests pass
  • make sure documentation can build
  • make sure demos are updated (no commented sections)

After merging

  • create tagged release
  • build doc on read the docs
  • update submodules in template repos

update travis CI


update travis CI


update travis CI


update travis CI


update travis CI

- pacify md linter
update travis CI: fix octave path


update travis CI


fix markdown


fix CI


update travis CI


update travis CI


update travis CI


update travis CI


update travis CI
[ENH] launch graphic windows and save output to func directory
@pep8speaks
Copy link

pep8speaks commented Oct 31, 2020

Hello @Remi-Gau! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 34:28: W291 trailing whitespace
Line 91:2: W292 no newline at end of file

Comment last updated at 2020-11-01 05:55:20 UTC

@codecov
Copy link

codecov bot commented Oct 31, 2020

Codecov Report

Merging #145 into master will increase coverage by 10.09%.
The diff coverage is 43.86%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #145       +/-   ##
===========================================
+ Coverage   33.83%   43.93%   +10.09%     
===========================================
  Files          39       81       +42     
  Lines         987     1607      +620     
===========================================
+ Hits          334      706      +372     
- Misses        653      901      +248     
Impacted Files Coverage Δ
src/QA/anatomicalQA.m 0.00% <0.00%> (ø)
src/QA/functionalQA.m 0.00% <0.00%> (ø)
src/batches/setBatchComputeVDM.m 0.00% <0.00%> (ø)
src/batches/setBatchCoregistration.m 0.00% <0.00%> (ø)
src/batches/setBatchCoregistrationFmap.m 0.00% <0.00%> (ø)
src/batches/setBatchCreateVDMs.m 0.00% <0.00%> (ø)
src/batches/setBatchFactorialDesign.m 0.00% <0.00%> (ø)
src/batches/setBatchImageCalculation.m 0.00% <0.00%> (ø)
src/batches/setBatchMeanAnatAndMask.m 0.00% <0.00%> (ø)
src/batches/setBatchReslice.m 0.00% <0.00%> (ø)
... and 140 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5392fd...dc6a5f0. Read the comment docs.

@Remi-Gau Remi-Gau merged commit 1530a16 into master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants