Skip to content

Conversation

@mwmaclean
Copy link
Collaborator

No description provided.

mwmaclean and others added 3 commits March 8, 2021 11:57
@Remi-Gau Remi-Gau mentioned this pull request Mar 8, 2021
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #313 (95dd456) into dev (c3511c7) will increase coverage by 1.93%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #313      +/-   ##
==========================================
+ Coverage   62.66%   64.59%   +1.93%     
==========================================
  Files         108      107       -1     
  Lines        1714     1675      -39     
==========================================
+ Hits         1074     1082       +8     
+ Misses        640      593      -47     
Impacted Files Coverage Δ
src/batches/setBatchAbnormalitiesDetectLesion.m 0.00% <0.00%> (ø)
src/batches/setBatchLesionOverlapMap.m 0.00% <0.00%> (ø)
src/batches/setBatchSegmentationDetectLesion.m 0.00% <0.00%> (ø)
src/batches/setBatchFactorialDesign.m 95.12% <0.00%> (-0.23%) ⬇️
src/workflows/bidsCopyRawFolder.m 82.71% <0.00%> (-0.22%) ⬇️
src/getData.m 100.00% <0.00%> (ø)
src/getPrefix.m 100.00% <0.00%> (ø)
src/QA/anatomicalQA.m 0.00% <0.00%> (ø)
src/QA/functionalQA.m 0.00% <0.00%> (ø)
src/getBoldFilename.m 100.00% <0.00%> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3511c7...fa149a9. Read the comment docs.

Copy link
Contributor

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave you some pointers for the next step

@Remi-Gau
Copy link
Contributor

Remi-Gau commented Mar 15, 2021

Will add a couple of comment here and then turn those into issues for later.

@Remi-Gau
Copy link
Contributor

Add template file to create new workflows

@Remi-Gau
Copy link
Contributor

Turn all Lesion* scripts into batches

src/batches/setBatchLesionAbnormalitiesDetection.m  
src/batches/setBatchLesionOverlapMap.m

@Remi-Gau Remi-Gau merged commit a058880 into cpp-lln-lab:dev Mar 15, 2021
@Remi-Gau
Copy link
Contributor

@all-contributors please add @mwmaclean for code, ideas

@allcontributors
Copy link
Contributor

@Remi-Gau

I've put up a pull request to add @mwmaclean! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants