Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
168 commits
Select commit Hold shift + click to select a range
b799936
add possibility to skip subject GLM QA
Remi-Gau Mar 6, 2021
a7be094
options are now saved in a cfg folder in the working directory
Remi-Gau Mar 6, 2021
770658b
Merge pull request #307 from Remi-Gau/remi-skip£_FFX_QA
Remi-Gau Mar 7, 2021
9e7219f
remove specific sourceMRI code which is not in common between the two…
marcobarilari Mar 8, 2021
c3a76e0
Merge pull request #311 from marcobarilari/marco_sourceSPringCleaning
marcobarilari Mar 8, 2021
daee136
add DetectLesion batch
mwmaclean Mar 8, 2021
bbd4e23
Apply suggestions from code review
mwmaclean Mar 8, 2021
2d31642
add 3 batches for lesion detection
mwmaclean Mar 8, 2021
49e01ea
add function to return list of subject to analyze
Remi-Gau Mar 9, 2021
116a51f
update getData and doc
Remi-Gau Mar 9, 2021
bd1e84b
remove call to groups in workflows and batches
Remi-Gau Mar 9, 2021
53a28a5
rename subID to subLabel
Remi-Gau Mar 9, 2021
babc809
update and refactor tests and lint
Remi-Gau Mar 9, 2021
a6cf65f
refactor tests
Remi-Gau Mar 9, 2021
6db0209
clean code base
Remi-Gau Mar 9, 2021
4d5b2f7
fix tests
Remi-Gau Mar 9, 2021
1f51b07
fixes #275
Remi-Gau Mar 9, 2021
212fd0c
fixes QA pipelines
Remi-Gau Mar 9, 2021
79c66d4
fix bug moving figures in bidsFFX
Remi-Gau Mar 9, 2021
40faeb6
add initCppSpm to face rep demo
Remi-Gau Mar 9, 2021
e764740
fix bugs in ds000001 demo
Remi-Gau Mar 9, 2021
7b14512
add initCppSpm to ds000114
Remi-Gau Mar 9, 2021
7eb4262
update github actions
Remi-Gau Mar 9, 2021
e70eeeb
fix issues with demo ds001168
Remi-Gau Mar 9, 2021
c668cd0
fix test
Remi-Gau Mar 10, 2021
a92a480
update test batch STC
Remi-Gau Mar 10, 2021
3a4cfd8
Merge pull request #314 from Remi-Gau/remi-drop_group
Remi-Gau Mar 10, 2021
84e7fc5
Merge pull request #308 from Remi-Gau/remi-save_options+
Remi-Gau Mar 10, 2021
910f2d3
use a string for anat session and not an index
Remi-Gau Mar 8, 2021
918a0f5
update default in doc
Remi-Gau Mar 8, 2021
bb183a9
mh fix
Remi-Gau Mar 10, 2021
f892f70
fix test getAnat
Remi-Gau Mar 10, 2021
362c078
Merge pull request #310 from Remi-Gau/remi-session_as_string
Remi-Gau Mar 10, 2021
322ab04
update help sections
Remi-Gau Mar 6, 2021
76aefab
refactor getInfo
Remi-Gau Mar 6, 2021
b06e57f
update getInfo to allow to filter query for extra information
Remi-Gau Mar 6, 2021
d63d8f7
add tests/utils folder to path for tests in CI and update tests README
Remi-Gau Mar 6, 2021
b2a3804
update help checkOptions
Remi-Gau Mar 6, 2021
acb9714
rename the setDefaultFields
Remi-Gau Mar 8, 2021
1ffd06c
update doc and lint
Remi-Gau Mar 8, 2021
0c06d48
allow setFields to overwrite the content of a structure
Remi-Gau Mar 8, 2021
37b6c3b
allow getInfo to only select a pre-specified session
Remi-Gau Mar 8, 2021
01705e9
fix wrongly resolved merge conflict
Remi-Gau Mar 8, 2021
bce10be
fix test after merge conflict resolution
Remi-Gau Mar 10, 2021
bec5e89
Merge pull request #309 from Remi-Gau/remi-query
Remi-Gau Mar 10, 2021
f22ee28
turn batch into a function
mwmaclean Mar 15, 2021
95dd456
rewrite batch structure
mwmaclean Mar 15, 2021
39afc47
change batch names
mwmaclean Mar 15, 2021
129de1f
add lesion segmentation workflow
mwmaclean Mar 15, 2021
fa149a9
rm group loop lesion segmentation workflow
mwmaclean Mar 15, 2021
a058880
Merge pull request #313 from mwmaclean/michele-detect_lesion
Remi-Gau Mar 15, 2021
a1c7924
change default folder structure and name for subject level GLM
Remi-Gau Mar 17, 2021
3cf8763
change default folder structure and name for group level GLM
Remi-Gau Mar 17, 2021
64fdf6a
update other tests
Remi-Gau Mar 17, 2021
0e1e76b
change subID to subLabel
Remi-Gau Mar 17, 2021
a3b1ae2
create createGlmDirName
Remi-Gau Mar 17, 2021
905ae0b
move dummy SPM.mat
Remi-Gau Mar 17, 2021
828c787
let subject level glm dir name be described by user
Remi-Gau Mar 17, 2021
f22b3f3
update RFXdir
Remi-Gau Mar 17, 2021
f64439e
update tests
Remi-Gau Mar 17, 2021
1f443e0
lint
Remi-Gau Mar 17, 2021
91f5bd2
add function to create valid camelCase strings
Remi-Gau Mar 18, 2021
591472a
make sure ffx and rfx dir description are vaild alphanumeric camel case
Remi-Gau Mar 18, 2021
bd9c5b4
Merge pull request #322 from Remi-Gau/remi-new_ffx_dir
Remi-Gau Mar 18, 2021
19ac14e
update credits and use initCppSpm to check dependencies
Remi-Gau Mar 18, 2021
14a881c
Merge pull request #324 from Remi-Gau/remi-updat_credits
Remi-Gau Mar 18, 2021
e663b84
start creating anat workflow
Remi-Gau Mar 19, 2021
b936859
improve initCppSpm to run only once per matlab session
Remi-Gau Mar 19, 2021
86b989a
fix saver option to save in cfg folder
Remi-Gau Mar 19, 2021
67ca6d0
refactor download and convert face rep data function
Remi-Gau Mar 19, 2021
95423e3
refactor download and convert face rep
Remi-Gau Mar 19, 2021
f112706
remove setting default empty for workflows
Remi-Gau Mar 19, 2021
ee2d612
update demos
Remi-Gau Mar 19, 2021
7586874
update bidsSegmentSkullstrip
Remi-Gau Mar 19, 2021
58253b3
update demo folders
Remi-Gau Mar 19, 2021
e6ff203
update CI folders
Remi-Gau Mar 19, 2021
fc27b7c
move dummy SPM.mat
Remi-Gau Mar 19, 2021
ffd9a1f
fix tests and lint
Remi-Gau Mar 19, 2021
472e11c
update gitignore
Remi-Gau Mar 19, 2021
09d55c6
update run test github action
Remi-Gau Mar 19, 2021
db73acc
Merge pull request #325 from Remi-Gau/remi-create_anat_wrokflow
Remi-Gau Mar 19, 2021
6e95fb5
add CPP_ROI as submodule
Remi-Gau Mar 19, 2021
77a568f
update roi demo
Remi-Gau Mar 19, 2021
a85d4dd
update doc setBatchReslice
Remi-Gau Mar 20, 2021
9dc0e89
add function to remove SPM prefix
Remi-Gau Mar 20, 2021
d710ccd
update print credits
Remi-Gau Mar 20, 2021
c04fa9f
update initCppSpm
Remi-Gau Mar 20, 2021
26edb93
remove extra mkdir to create dummy test data
Remi-Gau Mar 20, 2021
1e80183
update MoAE demo
Remi-Gau Mar 20, 2021
36f9855
update README
Remi-Gau Mar 21, 2021
e338f60
update submodule
Remi-Gau Mar 21, 2021
25863da
update submodule
Remi-Gau Mar 21, 2021
1af40c3
fix script creation dummy data
Remi-Gau Mar 21, 2021
afdf115
Merge pull request #326 from Remi-Gau/remi-add_roi_workflows
Remi-Gau Mar 21, 2021
3ed5e4c
turn batches into functions
mwmaclean Mar 15, 2021
93f6cc0
add batchLesion script
mwmaclean Mar 16, 2021
3967a91
add getOption for lesion
mwmaclean Mar 16, 2021
8a472b1
add group loop
mwmaclean Mar 16, 2021
529dce8
auto-fix style
mwmaclean Mar 16, 2021
2392346
fix bidsLesionWorkflow
Remi-Gau Mar 22, 2021
82ed2f0
lint
Remi-Gau Mar 22, 2021
870a1fc
copy figures to subect dir after lesion workflow
Remi-Gau Mar 22, 2021
4ffcf90
Merge pull request #328 from Remi-Gau/michele-detect_lesion
mwmaclean Mar 22, 2021
531c7e6
make sure GLM figures are saved
Remi-Gau Mar 22, 2021
f541c8d
Merge pull request #330 from Remi-Gau/dev
Remi-Gau Mar 23, 2021
ece5f19
update CPP_ROI submodule
Remi-Gau Mar 23, 2021
e99c925
Merge pull request #332 from Remi-Gau/remi-fix_ROI_format
Remi-Gau Mar 23, 2021
7c911e6
rename GLM design matrix figure output
Remi-Gau Mar 31, 2021
931efdf
make name of onsets file more bids compliant
Remi-Gau Mar 31, 2021
20afd17
add demo to run pipeline with several ouput resolutions
Remi-Gau Apr 1, 2021
42e27a6
make demo download data
Remi-Gau Apr 1, 2021
391cc14
lint
Remi-Gau Apr 2, 2021
e637962
make results output name more bids like
Remi-Gau Apr 2, 2021
c29e9fa
rename output of results for make the filenames fully bids
Remi-Gau Apr 2, 2021
0d81e48
refactor and update tests
Remi-Gau Apr 2, 2021
398cc94
update submodule
Remi-Gau Apr 2, 2021
d53b3e2
update tests
Remi-Gau Apr 2, 2021
a56c62e
update submodule
Remi-Gau Apr 2, 2021
eaa902d
Merge pull request #334 from Remi-Gau/remi-rename_glm_output
Remi-Gau Apr 2, 2021
3881062
Merge pull request #335 from Remi-Gau/remi-face_rep
Remi-Gau Apr 2, 2021
b2e0125
add demo to create ROI and extract data from GLM
Remi-Gau Apr 2, 2021
b9ac837
Merge pull request #337 from Remi-Gau/remi-demo_roi_extract_data
Remi-Gau Apr 2, 2021
a04294b
add slice display and depenencies
Remi-Gau Mar 11, 2021
5a36565
update initCppSpm
Remi-Gau Mar 11, 2021
48133ab
proof of principles for slice display
Remi-Gau Mar 11, 2021
5437646
improved slice display demo
Remi-Gau Apr 2, 2021
54e177e
also normalize skull stripped anat during spatial preprocessing
Remi-Gau Apr 2, 2021
1093cea
improve slice display demo
Remi-Gau Apr 2, 2021
3e70d9c
add submodule for brain colormaps
Remi-Gau Apr 2, 2021
faeb2bb
lint
Remi-Gau Apr 2, 2021
caf8cc9
fix typo
Remi-Gau Apr 2, 2021
e727bd9
Merge pull request #315 from Remi-Gau/remi-slice_display
Remi-Gau Apr 2, 2021
c6b1b96
create workflow to create ROI from atlas
Remi-Gau Apr 3, 2021
01c8578
Merge pull request #339 from Remi-Gau/dev
Remi-Gau Apr 3, 2021
6b5cac3
set up roi based GLMs
Remi-Gau Apr 3, 2021
9bf5906
add mars bar roi based GLM estimation
Remi-Gau Apr 3, 2021
2c88cfd
fit events and compute percent signal change
Remi-Gau Apr 3, 2021
382b8b7
refactor MoAE to allow running with octave
Remi-Gau Apr 3, 2021
b599754
update tests
Remi-Gau Apr 3, 2021
0eef7e1
fix test
Remi-Gau Apr 3, 2021
0c1ef80
update tests
Remi-Gau Apr 3, 2021
c57312c
update face rep demo
Remi-Gau Apr 3, 2021
bce592c
reset demos
Remi-Gau Apr 3, 2021
149a349
Merge branch 'master' into rel_0.3.0
Remi-Gau Apr 4, 2021
d3f0a1b
add errors in FFX and roi based GLMs to prevent running them with the…
Remi-Gau Apr 7, 2021
6010230
Merge pull request #340 from Remi-Gau/remi-roi_based_glm
Remi-Gau Apr 7, 2021
5264e28
Merge remote-tracking branch 'cpp-lln-lab/dev' into rel_1.0.0
Remi-Gau Apr 7, 2021
16d6655
update version.txt
Remi-Gau Apr 12, 2021
606e61d
fix system test
Remi-Gau Apr 12, 2021
cb9bb83
update miss hit CI
Remi-Gau Apr 12, 2021
12fc88f
update MH CI
Remi-Gau Apr 12, 2021
dc49fe5
adapt file naming schema for scripts and demo folder
Remi-Gau Apr 12, 2021
369ff07
rename demo folders and files
Remi-Gau Apr 12, 2021
0912e9a
update test load and check
Remi-Gau Apr 12, 2021
a9c9a09
mh fix
Remi-Gau Apr 12, 2021
ed1ba36
update READMEs
Remi-Gau Apr 13, 2021
cc2085c
update copyright demos
Remi-Gau Apr 13, 2021
c18f577
fix copyright tests
Remi-Gau Apr 13, 2021
6381287
update more copyrights
Remi-Gau Apr 13, 2021
977bf0a
update demos
Remi-Gau Apr 13, 2021
8d6fe7a
finish fixing copyright
Remi-Gau Apr 13, 2021
f1cc426
remove markdown linting
Remi-Gau Apr 13, 2021
5030c45
fix doc
Remi-Gau Apr 13, 2021
8ff5804
Merge pull request #350 from Remi-Gau/remi-prepare_release_1.0.0
Remi-Gau Apr 13, 2021
e3926c9
update system CI
Remi-Gau Apr 13, 2021
542a381
fix system test
Remi-Gau Apr 13, 2021
f8c5fb8
fix bidsRFX
Remi-Gau Apr 13, 2021
4f139c4
fix options demo
Remi-Gau Apr 13, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
32 changes: 0 additions & 32 deletions .github/workflows/check_markdown.yml

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: miss_hit
name: miss_hit_quality

on:
push:
Expand Down Expand Up @@ -29,10 +29,6 @@ jobs:
python -m pip install --upgrade pip setuptools
pip3 install -r requirements.txt

- name: MISS_HIT Code style
run: |
mh_style --process-slx

- name: MISS_HIT Metrics
run: |
mh_metric --ci
Expand Down
35 changes: 35 additions & 0 deletions .github/workflows/miss_hit_style.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
name: miss_hit_style

on:
push:
branches:
- master
pull_request:
branches: '*'

jobs:
build:

runs-on: ubuntu-latest

steps:

- uses: actions/checkout@v2
with:
submodules: true
fetch-depth: 1

- name: Set up Python 3.6
uses: actions/setup-python@v2
with:
python-version: 3.6

- name: Install dependencies
run: |
python -m pip install --upgrade pip setuptools
pip3 install -r requirements.txt

- name: MISS_HIT Code style
run: |
mh_style

17 changes: 3 additions & 14 deletions .github/workflows/run_system_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,20 +56,9 @@ jobs:
make -C spm12/src PLATFORM=octave install
octave $OCTFLAGS --eval "addpath(fullfile(pwd, 'spm12')); savepath();"

- name: Update octave path
run: |
octave $OCTFLAGS --eval "addpath(genpath(fullfile(pwd, 'lib'))); savepath();"
octave $OCTFLAGS --eval "addpath(genpath(fullfile(pwd, 'src'))); savepath();"

- name: Prepare data
run: |
output_folder='demos/MoAE/output/'
mkdir $output_folder
curl http://www.fil.ion.ucl.ac.uk/spm/download/data/MoAEpilot/MoAEpilot.bids.zip --output $output_folder'MoAEpilot.zip'
unzip $output_folder'MoAEpilot.zip' -d $output_folder


- name: Run system tests
run: |
cd demos/MoAE
octave $OCTFLAGS --eval "MoAEpilot_run"
cd manualTests/
octave $OCTFLAGS --eval "test_moae"

15 changes: 8 additions & 7 deletions .github/workflows/run_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,22 +62,23 @@ jobs:

- name: Update octave path
run: |
octave $OCTFLAGS --eval "addpath(genpath(fullfile(pwd, 'lib'))); savepath();"
octave $OCTFLAGS --eval "addpath(genpath(fullfile(pwd, 'src'))); savepath();"
octave $OCTFLAGS --eval "initCppSpm; savepath();"
octave $OCTFLAGS --eval "addpath(fullfile(pwd, 'tests', 'utils')); savepath();"

- name: Prepare data
run: |
output_folder='demos/MoAE/output/'
mkdir $output_folder
curl http://www.fil.ion.ucl.ac.uk/spm/download/data/MoAEpilot/MoAEpilot.bids.zip --output $output_folder'MoAEpilot.zip'
unzip $output_folder'MoAEpilot.zip' -d $output_folder
inputs_folder='demos/MoAE/inputs/'
mkdir $inputs_folder
curl http://www.fil.ion.ucl.ac.uk/spm/download/data/MoAEpilot/MoAEpilot.bids.zip --output $inputs_folder'MoAEpilot.zip'
unzip $inputs_folder'MoAEpilot.zip' -d $inputs_folder
mv $inputs_folder/MoAEpilot $inputs_folder/raw
cd tests
sh createDummyDataSet.sh
cd ..

- name: Run tests
run: |
octave $OCTFLAGS --eval "runTests"
octave $OCTFLAGS --eval "run_tests"
cat test_report.log | grep 0
bash <(curl -s https://codecov.io/bash)

20 changes: 8 additions & 12 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,27 +13,23 @@ options_task-*date*.json
onsets*_events.mat

# files in the demo folder related to running the demo analysis
demos/*/*.zip
demos/*/derivatives/*
demos/MoAE/output/*
demos/spm*/raw
demos/spm*/source
demos/*/outputs/
demos/*/inputs/
demos/*/*.nii
demos/*/cfg/*.json

# test folder and dummy data
tests/sub-01/*
tests/*.png
tests/group/*
tests/models/*.json
tests/dummyData/derivatives/cpp_spm/sub-*/*/*/*.nii*
tests/dummyData/derivatives/cpp_spm/sub-*/*/*/*.tsv
tests/dummyData/derivatives/cpp_spm/sub-*/*/*/*.txt
tests/dummyData/derivatives/cpp_spm/sub-*/*/*/*.json
tests/dummyData/derivatives/cpp_spm/sub-*/stats/*/*/*.nii*
tests/*/*.json
tests/dummyData/derivatives/cpp_spm*/sub-*/

# ignore content of the build folder of the doc
docs/build/*

# ignore virtual env
cpp_spm/*
env/*

# visual studio code stuff
.vscode
Expand Down
9 changes: 9 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,12 @@
[submodule "lib/spmup"]
path = lib/spmup
url = https://github.com/CPernet/spmup.git
[submodule "lib/CPP_ROI"]
path = lib/CPP_ROI
url = https://github.com/cpp-lln-lab/CPP_ROI.git
[submodule "lib/slice_display"]
path = lib/slice_display
url = https://github.com/bramzandbelt/slice_display.git
[submodule "lib/brain_colours"]
path = lib/brain_colours
url = https://github.com/CPernet/brain_colours.git
11 changes: 0 additions & 11 deletions .remarkrc

This file was deleted.

9 changes: 7 additions & 2 deletions .zenodo.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,16 @@
"affiliation": "Université Catholique de Louvain",
"name": "Gurtubay, Ane",
"orcid": "0000-0003-3824-2219"
},
},
{
"affiliation": "Université Catholique de Louvain",
"name": "Falagiarda, Federica",
"orcid": "0000-0001-7844-1605"
},
{
"affiliation": "Université de Montréal",
"name": "MacLean, Michèle",
"orcid": "0000-0002-0174-9326"
}
],
"keywords": [
Expand All @@ -49,4 +54,4 @@
],
"license": "GPL-3",
"upload_type": "software"
}
}
Loading