Skip to content

Conversation

@CerenB
Copy link
Collaborator

@CerenB CerenB commented Apr 12, 2021

It contains a function bidswholeBrainFuncMask which is using cpp-spm segmentation and skullstripping scripts on the mean functional image. The end product is binary mask for the segmented-skullstripped-mean functional image.

  • can be used to mask analysis (to get rid off smoothing spillover effects)
  • can be used when GLM will not be performed but still whole brain functional mask is need for some analysis (e.g. FFT)

@CerenB CerenB requested a review from Remi-Gau April 12, 2021 18:23
@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #353 (531ac49) into dev (bebca72) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #353      +/-   ##
==========================================
- Coverage   60.58%   60.49%   -0.10%     
==========================================
  Files         115      115              
  Lines        1865     1868       +3     
==========================================
  Hits         1130     1130              
- Misses        735      738       +3     
Impacted Files Coverage Δ
src/getPrefix.m 100.00% <ø> (ø)
src/workflows/bidsWholeBrainFuncMask.m 0.00% <ø> (ø)
src/workflows/bidsResults.m 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bebca72...531ac49. Read the comment docs.

@Remi-Gau Remi-Gau force-pushed the cer-skullStrip-demo branch from 99694e8 to 8fa2d4d Compare April 13, 2021 10:21
@Remi-Gau
Copy link
Contributor

Don't worry too much if you still get some errors with miss hit: we can clean those up a bit later on the dev branch itself or in another PR. :-)

@CerenB
Copy link
Collaborator Author

CerenB commented Apr 26, 2021

perseverance... the mh fix should be done now! let me know what you think!

@CerenB
Copy link
Collaborator Author

CerenB commented May 13, 2021

So this PR has been ready to be merged.
Though, when I use below function in MNI space (not in individual), there are some holes in mostly basal ganglia in the masks.
mask = bidsWholeBrainFuncMask(opt);
I'm using also different ImcalcDefault option (16bits).

Any ideas why it would happen? Not that I need to resolve this issue asap, mostly I'm wondering...

Screenshot 2021-05-13 at 13 07 20

@Remi-Gau Remi-Gau linked an issue Jun 14, 2021 that may be closed by this pull request
@Remi-Gau
Copy link
Contributor

OK @CerenB don't panic about the large number of new files committed as pre-commit weny a bit crazy and let miss_hit clean all our libraries...

@Remi-Gau
Copy link
Contributor

So this PR has been ready to be merged.
Though, when I use below function in MNI space (not in individual), there are some holes in mostly basal ganglia in the masks.
mask = bidsWholeBrainFuncMask(opt);
I'm using also different ImcalcDefault option (16bits).

Any ideas why it would happen? Not that I need to resolve this issue asap, mostly I'm wondering...

I checked and lowering the skull stripping threshold eventually worked at including all the stuff in the basal ganglia

opt.skullstrip.threshold = 0.5;

@Remi-Gau Remi-Gau merged commit 6696160 into cpp-lln-lab:dev Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENH] setBatchImageCalculation

2 participants