feat(discord_activity_tracker): docstrings, tests, and discord.py failure classification#201
Merged
wpak-ai merged 3 commits intoMay 14, 2026
Conversation
…tests and detailed model documentation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds discord.py-aware failure classification to core/errors, expands docstrings across discord_activity_tracker (models, services, commands, packages), and introduces extensive tests covering backfill, sync, export, preprocessing, Pinecone sync, and management-command behaviors. ChangesDiscord Tracker: Docs & Tests
Estimated code review effort 🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
discord_activity_tracker/tests/test_task_markdown_coverage.py (1)
153-164:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winAssert the auto-commit contract in the auto-commit test.
This test currently only verifies “no exception.” It should assert that
export_and_pushwas called withauto_commit=Trueto actually protect the intended behavior.Suggested assertion hardening
- with patch( + with patch( "discord_activity_tracker.sync.export.export_and_push", return_value=True, - ): + ) as m: task_markdown_export_and_push( dry_run=False, skip_markdown_export=False, skip_remote_push=False, guild_id=srv.server_id, collector=collector, ) + m.assert_called_once() + assert m.call_args.kwargs.get("auto_commit") is True🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@discord_activity_tracker/tests/test_task_markdown_coverage.py` around lines 153 - 164, The test currently only ensures task_markdown_export_and_push doesn't raise; update it to assert the auto-commit contract by verifying the patched export function (export.export_and_push) was called with auto_commit=True. Locate the patch around "discord_activity_tracker.sync.export.export_and_push" and after calling task_markdown_export_and_push add an assertion on the mock's call args/kwargs (e.g., mock.assert_called_once_with or inspect mock.call_args) to confirm auto_commit=True while preserving other expected args like guild_id, collector, dry_run/skip flags.
🧹 Nitpick comments (1)
discord_activity_tracker/tests/test_sync_chat_exporter.py (1)
683-697: ⚡ Quick winConsider asserting that
embedskey is absent from the converted output.The test verifies that
contentis preserved, but doesn't explicitly check that theembedskey has been removed fromout. Addingassert "embeds" not in outwould more directly validate the "ignored" behavior described in the test name.📝 Suggested assertion
out = convert_exporter_message_to_dict(raw, server_id=1, channel_id=2) assert out["content"] == "body" + assert "embeds" not in out from discord_activity_tracker.staging_schema import validate_normalized_message🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@discord_activity_tracker/tests/test_sync_chat_exporter.py` around lines 683 - 697, The test test_convert_exporter_message_with_embeds_key_ignored should explicitly assert that the embeds key was removed by convert_exporter_message_to_dict; add an assertion like assert "embeds" not in out after calling convert_exporter_message_to_dict (before validate_normalized_message) to ensure the converter ignores and drops the embeds field.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@core/errors.py`:
- Around line 195-209: The current branch only handles the exact exc_name
"HTTPException" and thus skips discord.py subclasses like Forbidden/NotFound
that also expose a status; change the gate so the status-based mapping runs for
any discord exception that exposes a status (e.g., replace the condition if
exc_name == "HTTPException": with a check like if hasattr(exc, "status") or if
status is not None after computing status = getattr(exc, "status", None)), then
keep the existing status -> CollectorFailureCategory mapping (RATE_LIMIT, AUTH,
NETWORK, UNKNOWN) so subclasses are classified correctly; reference the status
variable and the mapping logic in this block that returns
CollectorFailureCategory.
In `@discord_activity_tracker/tests/test_backfill_command_extra.py`:
- Line 81: The current assertion is too broad (assert "Failed" in out.getvalue()
or "Import complete" in out.getvalue()); change it to explicitly verify the
malformed-JSON path by asserting that the command output contains the specific
parse error message emitted by the backfill command (e.g., "Malformed JSON" or
"Failed to parse JSON") and does NOT contain the success summary "Import
complete". Update the assertion in the test (the failing line in
test_backfill_command_extra.py) to check for the exact error substring and
assert "Import complete" not in out.getvalue() so the test only passes when bad
JSON is correctly detected.
In `@discord_activity_tracker/tests/test_preprocessor_extra.py`:
- Around line 89-109: The test name misstates its intent: rename the test
function test_chain_to_document_short_content_returns_none to reflect it asserts
a non-None result (e.g., test_chain_to_document_long_content_returns_document)
or change the input to short content and assert None; specifically update the
test definition (the function name) or modify the root.content ("x" * 80) and
the assertion against _chain_to_document([root]) so the name matches the
behavior in the test.
In `@discord_activity_tracker/tests/test_run_command_coverage.py`:
- Around line 216-224: The test test_resolve_bounds_since_naive_becomes_utc is
using a UTC-aware timestamp ("...Z") instead of a naive one; update the call to
_resolve_exporter_date_bounds to pass a truly naive ISO timestamp (e.g.
"2026-04-01T00:00:00" without the Z) for the "since" value so the test verifies
naive→UTC normalization, and keep the existing assertions that after is not None
and after.tzinfo is not None while before remains None.
- Around line 167-180: Test currently only ensures no exceptions; update
test_handle_core_skip_pinecone_logs to patch "task_discord_sync" and
"task_markdown_export_and_push" as mocks (use patch(...) as mock_sync,
patch(...) as mock_md), call collector.cmd._handle_core(collector.options,
collector) with skip_pinecone=True, then assert mock_sync.assert_not_called() to
confirm Pinecone sync was skipped (you may also assert
mock_md.assert_called_once() if you want to ensure other tasks still ran).
In `@discord_activity_tracker/tests/test_sync_client.py`:
- Line 427: The test unpacks an unused binding named "inner" from
"mock_discord_pkg" (e.g., lines where you have "m, inner = mock_discord_pkg"),
which triggers lint RUF059; fix by removing the unused binding—either unpack to
a throwaway underscore ("m, _ = mock_discord_pkg") or only assign "m" (e.g., "m
= mock_discord_pkg[0]" or equivalent) wherever "inner" is not used (search for
occurrences of the variables "m", "inner", and "mock_discord_pkg" to update
them).
In `@discord_activity_tracker/tests/test_task_discord_sync_coverage.py`:
- Line 38: Ruff flags literal token strings in test fixtures (e.g.,
settings.DISCORD_USER_TOKEN and other similar assignments) as hardcoded secrets;
change those literal assignments to generate non-secret placeholder tokens at
runtime (for example, import secrets and assign settings.DISCORD_USER_TOKEN =
secrets.token_hex(16) or use a small pytest fixture that returns
secrets.token_hex(16)) so no raw string token appears in source; ensure you
update every occurrence referenced (the other token assignments noted in the
comment) to use the runtime-generated value and add the necessary import or
fixture to the test file.
---
Outside diff comments:
In `@discord_activity_tracker/tests/test_task_markdown_coverage.py`:
- Around line 153-164: The test currently only ensures
task_markdown_export_and_push doesn't raise; update it to assert the auto-commit
contract by verifying the patched export function (export.export_and_push) was
called with auto_commit=True. Locate the patch around
"discord_activity_tracker.sync.export.export_and_push" and after calling
task_markdown_export_and_push add an assertion on the mock's call args/kwargs
(e.g., mock.assert_called_once_with or inspect mock.call_args) to confirm
auto_commit=True while preserving other expected args like guild_id, collector,
dry_run/skip flags.
---
Nitpick comments:
In `@discord_activity_tracker/tests/test_sync_chat_exporter.py`:
- Around line 683-697: The test
test_convert_exporter_message_with_embeds_key_ignored should explicitly assert
that the embeds key was removed by convert_exporter_message_to_dict; add an
assertion like assert "embeds" not in out after calling
convert_exporter_message_to_dict (before validate_normalized_message) to ensure
the converter ignores and drops the embeds field.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6d33919b-68d8-4077-bd71-447b5003ccd8
📒 Files selected for processing (26)
core/errors.pydiscord_activity_tracker/__init__.pydiscord_activity_tracker/management/__init__.pydiscord_activity_tracker/management/commands/__init__.pydiscord_activity_tracker/management/commands/backfill_discord_activity_tracker.pydiscord_activity_tracker/management/commands/run_discord_activity_tracker.pydiscord_activity_tracker/models.pydiscord_activity_tracker/services.pydiscord_activity_tracker/sync/__init__.pydiscord_activity_tracker/tests/test_backfill_command_extra.pydiscord_activity_tracker/tests/test_chat_exporter_branch_coverage.pydiscord_activity_tracker/tests/test_export_sync_coverage.pydiscord_activity_tracker/tests/test_exporter_window.pydiscord_activity_tracker/tests/test_failure_classification.pydiscord_activity_tracker/tests/test_pinecone_runner_coverage.pydiscord_activity_tracker/tests/test_preprocessor_extra.pydiscord_activity_tracker/tests/test_run_command_coverage.pydiscord_activity_tracker/tests/test_staging_schema_extra.pydiscord_activity_tracker/tests/test_sync_chat_exporter.pydiscord_activity_tracker/tests/test_sync_client.pydiscord_activity_tracker/tests/test_task_discord_sync_coverage.pydiscord_activity_tracker/tests/test_task_markdown_coverage.pydiscord_activity_tracker/tests/test_workspace_clear_staging.pydiscord_activity_tracker/tests/test_write_staging_json_schema_script.pydocs/Service_API.mddocs/service_api/discord_activity_tracker.md
…d enhance test coverage
Collaborator
Author
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (5)
discord_activity_tracker/tests/test_failure_classification.py (1)
64-68: ⚡ Quick winAdd direct tests for remaining Discord AUTH-name branches.
classify_failureexplicitly mapsPrivilegedIntentsRequiredandClientExceptiontoAUTH, but this file currently only assertsLoginFailure.🧪 Suggested test additions
+def test_discord_privileged_intents_required_is_auth(): + cls = type("PrivilegedIntentsRequired", (Exception,), {}) + cls.__module__ = "discord.errors" + assert classify_failure(cls()) is CollectorFailureCategory.AUTH + + +def test_discord_client_exception_is_auth(): + cls = type("ClientException", (Exception,), {}) + cls.__module__ = "discord.errors" + assert classify_failure(cls()) is CollectorFailureCategory.AUTH🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@discord_activity_tracker/tests/test_failure_classification.py` around lines 64 - 68, The tests only cover LoginFailure but classify_failure also maps PrivilegedIntentsRequired and ClientException to AUTH; add two new unit tests in discord_activity_tracker/tests/test_failure_classification.py that mirror test_discord_login_failure_is_auth: create dynamic exception classes named "PrivilegedIntentsRequired" and "ClientException" (set their __module__ to "discord.errors"), instantiate them and assert classify_failure(instance) is CollectorFailureCategory.AUTH, referencing classify_failure and CollectorFailureCategory to locate the logic under test.discord_activity_tracker/tests/test_pinecone_runner_coverage.py (1)
12-28: ⚡ Quick winStrengthen skip-path tests with explicit negative call assertions.
These tests currently pass on “no exception” only. Patch
call_commandand assert it is not called so skip behavior is actually enforced.Proposed test hardening
def test_task_discord_pinecone_sync_dry_run(): - task_discord_pinecone_sync(dry_run=True) + with patch("discord_activity_tracker.pinecone_runner.call_command") as cc: + task_discord_pinecone_sync(dry_run=True) + cc.assert_not_called() @@ def test_task_discord_pinecone_sync_skips_when_app_type_empty(monkeypatch, settings): monkeypatch.setattr(settings, "PINECONE_DISCORD_APP_TYPE", "") monkeypatch.setattr(settings, "PINECONE_DISCORD_NAMESPACE", "ns") - task_discord_pinecone_sync(dry_run=False) + with patch("discord_activity_tracker.pinecone_runner.call_command") as cc: + task_discord_pinecone_sync(dry_run=False) + cc.assert_not_called() @@ def test_task_discord_pinecone_sync_skips_when_namespace_empty(monkeypatch, settings): monkeypatch.setattr(settings, "PINECONE_DISCORD_APP_TYPE", "app") monkeypatch.setattr(settings, "PINECONE_DISCORD_NAMESPACE", " ") - task_discord_pinecone_sync(dry_run=False) + with patch("discord_activity_tracker.pinecone_runner.call_command") as cc: + task_discord_pinecone_sync(dry_run=False) + cc.assert_not_called()🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@discord_activity_tracker/tests/test_pinecone_runner_coverage.py` around lines 12 - 28, The skip-path tests for task_discord_pinecone_sync are brittle because they only ensure no exception; patch django.core.management.call_command (or monkeypatch the call_command symbol used by task_discord_pinecone_sync) in the two tests test_task_discord_pinecone_sync_skips_when_app_type_empty and test_task_discord_pinecone_sync_skips_when_namespace_empty, run task_discord_pinecone_sync(dry_run=False), and assert that the patched call_command was not called (e.g., using a spy/mock with assert_not_called) to explicitly verify the skip behavior.discord_activity_tracker/tests/test_task_discord_sync_coverage.py (1)
41-79: ⚡ Quick winMake early-return tests assert that sync side effects are skipped.
The current assertions only verify “no crash.” Patch exporter/persist entry points and assert they are not invoked in
skip_discord_syncanddry_runpaths.Proposed assertion upgrade
def test_task_discord_sync_skip_returns_early(settings): @@ - task_discord_sync( - dry_run=False, - skip_discord_sync=True, - user_token=tok, - guild_id=1, - channel_ids=[], - after_date=None, - before_date=None, - collector=collector, - ) + with patch( + "discord_activity_tracker.management.commands.run_discord_activity_tracker.export_guild_to_json" + ) as export_mock: + task_discord_sync( + dry_run=False, + skip_discord_sync=True, + user_token=tok, + guild_id=1, + channel_ids=[], + after_date=None, + before_date=None, + collector=collector, + ) + export_mock.assert_not_called() @@ def test_task_discord_sync_dry_run_returns_early(settings): @@ - task_discord_sync( - dry_run=True, - skip_discord_sync=False, - user_token=tok, - guild_id=1, - channel_ids=[], - after_date=None, - before_date=None, - collector=collector, - ) + with patch( + "discord_activity_tracker.management.commands.run_discord_activity_tracker.export_guild_to_json" + ) as export_mock: + task_discord_sync( + dry_run=True, + skip_discord_sync=False, + user_token=tok, + guild_id=1, + channel_ids=[], + after_date=None, + before_date=None, + collector=collector, + ) + export_mock.assert_not_called()🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@discord_activity_tracker/tests/test_task_discord_sync_coverage.py` around lines 41 - 79, Update these two tests so they assert sync side effects are skipped by patching/mocking the exporter/persist entry points that task_discord_sync would call and asserting they were NOT invoked; locate task_discord_sync and the DiscordActivityCollector instantiation in the tests, inject mocks for the collector's export/persist callables (or the module-level exporter.persist functions that task_discord_sync uses) before calling task_discord_sync, then assert the mocked methods (e.g., export(), persist(), or whatever entry-point names task_discord_sync invokes) have zero calls for both skip_discord_sync and dry_run cases.discord_activity_tracker/tests/test_run_command_coverage.py (1)
109-164: ⚡ Quick winIsolate Pinecone side effects in tests not targeting Pinecone behavior.
Patch
task_discord_pinecone_sync(or setskip_pinecone=True) in these orchestration tests to avoid environment-dependent behavior when Pinecone settings are present.Also applies to: 237-252
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@discord_activity_tracker/tests/test_run_command_coverage.py` around lines 109 - 164, The orchestration tests call core tasks but don't isolate Pinecone side effects; update the tests (e.g., test_handle_core_task_sync_skips_markdown, test_handle_core_task_export_skips_sync, test_handle_core_non_dry_calls_sync_and_markdown and the similar block at 237-252) to either patch "discord_activity_tracker.management.commands.run_discord_activity_tracker.task_discord_pinecone_sync" or set collector.options["skip_pinecone"]=True before invoking collector.cmd._handle_core so Pinecone behavior is mocked out and the tests no longer depend on Pinecone environment settings.discord_activity_tracker/tests/test_task_markdown_coverage.py (1)
17-48: ⚡ Quick winAdd explicit assertions for branch intent in no-op/flag paths.
These tests currently pass on “no exception” only. Please assert observable behavior (e.g.,
export_and_pushnot called for skip/no-context, and called with expected flags for auto-commit) so regressions are caught.Also applies to: 141-164
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@discord_activity_tracker/tests/test_task_markdown_coverage.py` around lines 17 - 48, The tests only check for no exceptions; update them to assert the intended branch behavior by mocking/spy-ing the collector/export function: in test_task_markdown_skip_export replace or attach a MagicMock to DiscordActivityCollector.export_and_push and assert it was not called when skip_markdown_export=True; in test_task_markdown_no_context_path similarly assert export_and_push is not called when DISCORD_CONTEXT_REPO_PATH is empty; also add assertions in the other referenced tests (lines ~141-164) to verify export_and_push is called with the expected flags (e.g., auto_commit True/False) when not skipped by checking the mock call args. Ensure you reference the collector instance used in the tests and use mock.assert_not_called() / mock.assert_called_once_with(...) to validate behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@discord_activity_tracker/tests/test_sync_chat_exporter.py`:
- Around line 683-697: The test
test_convert_exporter_message_with_embeds_key_ignored should explicitly assert
that embeds are dropped: after calling convert_exporter_message_to_dict(raw,
server_id=1, channel_id=2) and validating with validate_normalized_message(out,
source="embed-test"), add an assertion referencing the same output (out) that
verifies embeds is not present or is empty (e.g., assert "embeds" not in out or
out.get("embeds") in (None, [], {})) so any regression that preserves the embeds
key will fail.
---
Nitpick comments:
In `@discord_activity_tracker/tests/test_failure_classification.py`:
- Around line 64-68: The tests only cover LoginFailure but classify_failure also
maps PrivilegedIntentsRequired and ClientException to AUTH; add two new unit
tests in discord_activity_tracker/tests/test_failure_classification.py that
mirror test_discord_login_failure_is_auth: create dynamic exception classes
named "PrivilegedIntentsRequired" and "ClientException" (set their __module__ to
"discord.errors"), instantiate them and assert classify_failure(instance) is
CollectorFailureCategory.AUTH, referencing classify_failure and
CollectorFailureCategory to locate the logic under test.
In `@discord_activity_tracker/tests/test_pinecone_runner_coverage.py`:
- Around line 12-28: The skip-path tests for task_discord_pinecone_sync are
brittle because they only ensure no exception; patch
django.core.management.call_command (or monkeypatch the call_command symbol used
by task_discord_pinecone_sync) in the two tests
test_task_discord_pinecone_sync_skips_when_app_type_empty and
test_task_discord_pinecone_sync_skips_when_namespace_empty, run
task_discord_pinecone_sync(dry_run=False), and assert that the patched
call_command was not called (e.g., using a spy/mock with assert_not_called) to
explicitly verify the skip behavior.
In `@discord_activity_tracker/tests/test_run_command_coverage.py`:
- Around line 109-164: The orchestration tests call core tasks but don't isolate
Pinecone side effects; update the tests (e.g.,
test_handle_core_task_sync_skips_markdown,
test_handle_core_task_export_skips_sync,
test_handle_core_non_dry_calls_sync_and_markdown and the similar block at
237-252) to either patch
"discord_activity_tracker.management.commands.run_discord_activity_tracker.task_discord_pinecone_sync"
or set collector.options["skip_pinecone"]=True before invoking
collector.cmd._handle_core so Pinecone behavior is mocked out and the tests no
longer depend on Pinecone environment settings.
In `@discord_activity_tracker/tests/test_task_discord_sync_coverage.py`:
- Around line 41-79: Update these two tests so they assert sync side effects are
skipped by patching/mocking the exporter/persist entry points that
task_discord_sync would call and asserting they were NOT invoked; locate
task_discord_sync and the DiscordActivityCollector instantiation in the tests,
inject mocks for the collector's export/persist callables (or the module-level
exporter.persist functions that task_discord_sync uses) before calling
task_discord_sync, then assert the mocked methods (e.g., export(), persist(), or
whatever entry-point names task_discord_sync invokes) have zero calls for both
skip_discord_sync and dry_run cases.
In `@discord_activity_tracker/tests/test_task_markdown_coverage.py`:
- Around line 17-48: The tests only check for no exceptions; update them to
assert the intended branch behavior by mocking/spy-ing the collector/export
function: in test_task_markdown_skip_export replace or attach a MagicMock to
DiscordActivityCollector.export_and_push and assert it was not called when
skip_markdown_export=True; in test_task_markdown_no_context_path similarly
assert export_and_push is not called when DISCORD_CONTEXT_REPO_PATH is empty;
also add assertions in the other referenced tests (lines ~141-164) to verify
export_and_push is called with the expected flags (e.g., auto_commit True/False)
when not skipped by checking the mock call args. Ensure you reference the
collector instance used in the tests and use mock.assert_not_called() /
mock.assert_called_once_with(...) to validate behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 656a2dc3-ec6d-4613-93e3-226996210ae6
📒 Files selected for processing (26)
core/errors.pydiscord_activity_tracker/__init__.pydiscord_activity_tracker/management/__init__.pydiscord_activity_tracker/management/commands/__init__.pydiscord_activity_tracker/management/commands/backfill_discord_activity_tracker.pydiscord_activity_tracker/management/commands/run_discord_activity_tracker.pydiscord_activity_tracker/models.pydiscord_activity_tracker/services.pydiscord_activity_tracker/sync/__init__.pydiscord_activity_tracker/tests/test_backfill_command_extra.pydiscord_activity_tracker/tests/test_chat_exporter_branch_coverage.pydiscord_activity_tracker/tests/test_export_sync_coverage.pydiscord_activity_tracker/tests/test_exporter_window.pydiscord_activity_tracker/tests/test_failure_classification.pydiscord_activity_tracker/tests/test_pinecone_runner_coverage.pydiscord_activity_tracker/tests/test_preprocessor_extra.pydiscord_activity_tracker/tests/test_run_command_coverage.pydiscord_activity_tracker/tests/test_staging_schema_extra.pydiscord_activity_tracker/tests/test_sync_chat_exporter.pydiscord_activity_tracker/tests/test_sync_client.pydiscord_activity_tracker/tests/test_task_discord_sync_coverage.pydiscord_activity_tracker/tests/test_task_markdown_coverage.pydiscord_activity_tracker/tests/test_workspace_clear_staging.pydiscord_activity_tracker/tests/test_write_staging_json_schema_script.pydocs/Service_API.mddocs/service_api/discord_activity_tracker.md
jonathanMLDev
approved these changes
May 14, 2026
wpak-ai
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__init__, management commands,syncpackage, models, and services (module + function docstrings aligned with the service API).core.errors.classify_failure(e.g.HTTPExceptionstatus codes, login / privileged intents / client errors) alongside existing HTTP and transport handling.docs/Service_API.mdanddocs/service_api/discord_activity_tracker.mdto match the documented behavior and commands.Test plan
pytest(or project test command) fordiscord_activity_trackerandcoretests touched by this changemanage.py run_discord_activity_tracker/backfill_discord_activity_trackerhelp or dry-run if applicable in your environmentCloses #190, closes #192
Summary by CodeRabbit
Documentation
Bug Fixes / Improvements
Tests