Skip to content

why-not-tmc#128

Merged
vinniefalco merged 2 commits intocppalliance:developfrom
vinniefalco:develop
Feb 3, 2026
Merged

why-not-tmc#128
vinniefalco merged 2 commits intocppalliance:developfrom
vinniefalco:develop

Conversation

@vinniefalco
Copy link
Member

@vinniefalco vinniefalco commented Feb 3, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Resolved compilation failures on Windows MSVC by adjusting compiler optimization settings across all build configurations (default, Release, RelWithDebInfo, and MinSizeRel), ensuring successful builds without errors.

@coderabbitai
Copy link

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

A set_target_properties call was added to CMakeLists.txt to disable Interprocedural Optimization (IPO) for the boost_capy target across all build configurations (default, RELEASE, RELWITHDEBINFO, and MINSIZEREL) to prevent LNK2016 errors on MSVC.

Changes

Cohort / File(s) Summary
IPO Configuration
CMakeLists.txt
Disable Interprocedural Optimization (INTERPROCEDURAL_OPTIMIZATION) properties for the public boost_capy target across all build configurations to avoid MSVC LNK2016 errors.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A rabbit hops through CMake's delight,
IPO's turned off, MSVC links just right!
No LNK2016 shall trouble the build,
Optimization's gentle touch now stilled.
Boost capy bounds free, at last! 🎉

🚥 Pre-merge checks | ✅ 1 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'why-not-tmc' is cryptic and does not clearly convey the actual change: disabling IPO/LTCG on the boost_capy target to fix MSVC LNK2016 errors. Rename the title to something descriptive like 'Disable IPO for boost_capy to fix MSVC LNK2016 errors' that clearly explains the primary change.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://128.capy.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-02-03 19:58:38 UTC

@vinniefalco vinniefalco merged commit d9910b2 into cppalliance:develop Feb 3, 2026
15 checks passed
@cppalliance-bot
Copy link

GCOVR code coverage report https://128.capy.prtest3.cppalliance.org/gcovr/index.html
LCOV code coverage report https://128.capy.prtest3.cppalliance.org/genhtml/index.html
Coverage Diff Report https://128.capy.prtest3.cppalliance.org/diff-report/index.html

Build time: 2026-02-03 20:04:14 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants