Skip to content

Conversation

@sgerbino
Copy link
Collaborator

@sgerbino sgerbino commented Jan 26, 2026

The lcov command was correctly filtering coverage to only include files from corosio's include/ and src/ directories, but the codecov action was running its own gcov plugin which generated coverage data from ALL .gcno files in the build directory (including capy, url, system headers, etc.).

Adding disable_search and empty plugins options ensures codecov only uploads the pre-filtered coverage.info file from lcov.

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow configuration for improved codecov integration.

✏️ Tip: You can customize this high-level summary in your review settings.

The lcov command was correctly filtering coverage to only include
files from corosio's include/ and src/ directories, but the codecov
action was running its own gcov plugin which generated coverage data
from ALL .gcno files in the build directory (including capy, url,
system headers, etc.).

Adding disable_search and empty plugins options ensures codecov only
uploads the pre-filtered coverage.info file from lcov.
@sgerbino sgerbino merged commit 522f403 into cppalliance:develop Jan 26, 2026
12 of 14 checks passed
@sgerbino sgerbino deleted the fix/coverage branch January 26, 2026 17:37
@coderabbitai
Copy link

coderabbitai bot commented Jan 26, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

A minor configuration update to the GitHub Actions CI workflow that enhances the Codecov upload step by disabling search functionality and clearing the plugins list, affecting only two lines in the workflow file.

Changes

Cohort / File(s) Summary
GitHub Actions CI Configuration
.github/workflows/ci.yml
Added disable_search: true and plugins: '' parameters to the Codecov upload step configuration

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • CodeCov improvements #82: Modifies the Codecov integration in the GitHub Actions CI workflow, specifically the upload step configuration

Poem

🐰 A tweak so small, a config refined,
Codecov flags adjusted with care,
Search disabled, plugins undefined,
The CI pipeline breathes cleaner air! ✨


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.08%. Comparing base (f78a90f) to head (f87c142).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop      #84       +/-   ##
============================================
+ Coverage    38.76%   84.08%   +45.32%     
============================================
  Files          258       43      -215     
  Lines        14388     2822    -11566     
  Branches      1453        0     -1453     
============================================
- Hits          5577     2373     -3204     
+ Misses        8744      449     -8295     
+ Partials        67        0       -67     

see 215 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f78a90f...f87c142. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant