Add integration-auth workflow.#74
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThis PR adds complete integration testing infrastructure for Boost endpoint authentication. A new GitHub Actions workflow triggers on push and PR events, executes a test orchestration script that manages Docker stack setup and teardown, and runs pytest against a new integration test suite validating API token requirements and public endpoint accessibility. ChangesBoost Endpoint Authentication Testing
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/integration-auth.yml (1)
13-17: ⚡ Quick winSet least-privilege
GITHUB_TOKENpermissions explicitly.This workflow does not define
permissions, so token scope depends on repo/org defaults. Lock it down for CI safety.🔐 Proposed hardening
name: Integration auth on: push: branches: [main, develop] pull_request: branches: [main, develop] +permissions: + contents: read + jobs: integration-auth:🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/integration-auth.yml around lines 13 - 17, Add an explicit least-privilege GITHUB_TOKEN permissions block for the workflow/job so the token scope is not inherited from repo defaults: in the workflow containing the job named "integration-auth" add a permissions: mapping (at top-level or scoped to that job) that lists only the minimal scopes the CI needs (e.g., read-only for contents, packages, actions, or write only for specific items if required); update the "integration-auth" job to use that permissions block to lock down the token.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/integration-auth.sh`:
- Line 43: Update the install command in scripts/integration-auth.sh (and the
same occurrence in scripts/integration-smoke.sh) to pin pytest to the version
from uv.lock and invoke pip via the Python module; replace the unpinned `pip
install --quiet pytest` invocation with `python -m pip install --quiet
"pytest==9.0.3"` so CI runs are reproducible.
---
Nitpick comments:
In @.github/workflows/integration-auth.yml:
- Around line 13-17: Add an explicit least-privilege GITHUB_TOKEN permissions
block for the workflow/job so the token scope is not inherited from repo
defaults: in the workflow containing the job named "integration-auth" add a
permissions: mapping (at top-level or scoped to that job) that lists only the
minimal scopes the CI needs (e.g., read-only for contents, packages, actions, or
write only for specific items if required); update the "integration-auth" job to
use that permissions block to lock down the token.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: fa6f7615-4157-4494-b88e-1f710150aea7
📒 Files selected for processing (3)
.github/workflows/integration-auth.ymlscripts/integration-auth.shtests/integration/test_auth.py
|
Actionable comments posted: 0 |
Close #63
Summary by CodeRabbit
Tests
Chores