Skip to content

Conversation

@mborland
Copy link
Member

Also completely removes the now incorrect subtraction impl

Closes: #1041

@mborland mborland added this to the v6.0.0 milestone Sep 15, 2025
@mborland mborland self-assigned this Sep 15, 2025
@mborland mborland added the Bug Something isn't working label Sep 15, 2025
@codecov
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.3%. Comparing base (b212b95) to head (d032639).
⚠️ Report is 8 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #1065     +/-   ##
=========================================
- Coverage     98.3%   98.3%   -0.0%     
=========================================
  Files          254     253      -1     
  Lines        16622   16593     -29     
  Branches      1850    1851      +1     
=========================================
- Hits         16339   16310     -29     
  Misses         283     283             
Files with missing lines Coverage Δ
include/boost/decimal/decimal128_t.hpp 97.9% <100.0%> (-<0.1%) ⬇️
include/boost/decimal/decimal32_t.hpp 96.6% <ø> (ø)
include/boost/decimal/decimal64_t.hpp 97.2% <ø> (ø)
include/boost/decimal/decimal_fast128_t.hpp 97.9% <100.0%> (ø)
include/boost/decimal/decimal_fast64_t.hpp 97.9% <ø> (ø)
include/boost/decimal/detail/u256.hpp 98.6% <100.0%> (+0.1%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b212b95...d032639. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mborland mborland merged commit 2930a3b into develop Sep 16, 2025
78 checks passed
@mborland mborland deleted the 1041 branch September 16, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix rounding in decimal128_t division

2 participants