Skip to content

Conversation

@mborland
Copy link
Member

Closes: #1153

@cppalliance-bot
Copy link

cppalliance-bot commented Oct 22, 2025

An automated preview of the documentation is available at https://1160.decimal.prtest3.cppalliance.org/libs/decimal/doc/html/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2025-10-23 11:52:35 UTC

@mborland mborland self-assigned this Oct 23, 2025
@mborland mborland added enhancement New feature or request Boost Review Collected Comments from Boost Review Period labels Oct 23, 2025
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 98.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 99.4%. Comparing base (c24dd80) to head (c7ee8b9).
⚠️ Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
include/boost/decimal/charconv.hpp 93.4% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #1160     +/-   ##
=========================================
+ Coverage     99.4%   99.4%   +0.1%     
=========================================
  Files          254     254             
  Lines        17395   17446     +51     
  Branches      1891    1897      +6     
=========================================
+ Hits         17274   17326     +52     
+ Misses         121     120      -1     
Files with missing lines Coverage Δ
include/boost/decimal/detail/parser.hpp 95.9% <100.0%> (ø)
test/test_charconv_preservation.cpp 100.0% <100.0%> (ø)
test/test_string_construction.cpp 100.0% <100.0%> (ø)
include/boost/decimal/charconv.hpp 97.6% <93.4%> (+0.3%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c24dd80...c7ee8b9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mborland mborland merged commit 5cd9440 into develop Oct 23, 2025
74 checks passed
@mborland mborland deleted the 1153 branch October 23, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Boost Review Collected Comments from Boost Review Period enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add cohort preserving from_chars scientific format

3 participants