refactor settings#194
Conversation
|
An automated preview of the documentation is available at https://194.http-proto.prtest.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2025-11-21 04:28:50 UTC |
| namespace boost { | ||
| namespace http_proto { | ||
|
|
||
| class zlib_filter |
There was a problem hiding this comment.
Should this go into the detail directory?
There is also a zlib_filter used by the serializer, so we would have a name collision when we try to move it out.
There was a problem hiding this comment.
I want to break out more of the stuff in parser.cpp into its own headers in src/. And this could probably use some tidying. Does it need to go into detail? There is no "correct" answer. Users can't see the types, so it matters little what namespace it goes into. If there is a conflict with serializer, maybe we just make them nested types of parser and serializer?
| rts::brotli::decode_service* brotli_decode = nullptr; | ||
| rts::brotli::encode_service* brotli_encode = nullptr; | ||
| rts::zlib::inflate_service* zlib_deflate = nullptr; | ||
| rts::zlib::inflate_service* zlib_inflate = nullptr; |
There was a problem hiding this comment.
What would be the use case for brotli_encode and zlib_deflate in parser_config?
There was a problem hiding this comment.
Originally I had the parser and serializer settings together in 1 struct. I might go back to that. These extra pointers are harmless for now and there will be more changes coming, I just dont know exactly what the right API is so we are exploring it.
3 participants
No description provided.