ci: PR template and stricter danger.js review checks#1202
Conversation
🧾 Changes by Scope
🔝 Top Files
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1202 +/- ##
========================================
Coverage 82.12% 82.12%
========================================
Files 33 33
Lines 3149 3149
Branches 734 734
========================================
Hits 2586 2586
Misses 387 387
Partials 176 176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f884b346eb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
An automated preview of the documentation is available at https://1202.mrdocs.prtest2.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-05-13 21:44:03 UTC |
Adds an aggregate source-churn warning (5000 lines) so large PRs are flagged even when individual commits stay under the per-commit limit, and replaces the fixed 40-character description floor with a log-scaled threshold (~80 * log2(churn)) so descriptions are expected to grow with the size of the change. Template scaffolding (HTML comments, Markdown headers, standalone italic placeholders, and `- **Label**: _placeholder_` bullets) is stripped from the body before measurement so an unfilled template cannot inflate the length count or mask the testing-mention check via the `## Testing` header.
Prompts contributors to describe the change, enumerate per-area impacts, document testing (including any workflow updates), and note documentation changes. Placeholders are visible italic text so any section a contributor forgets to replace stands out in the rendered PR.
2 participants
Part of our ongoing work to make review processes more efficient now that AI-assisted contributions routinely produce large diffs. Inspired by LLVM's AI Tool Use Policy, this PR includes a few improvements to the automated review workflow. Existing danger.js coverage was per-commit and used a fixed 40-character description floor, which let well-sliced multi-thousand-line PRs with two-sentence bodies land without any automated signal. Three changes here address that:
.gitignoreentries for Python coverage artifacts thatbootstrap.pyandutil/bootstrap/leave behind.Changes
.github/pull_request_template.md; two new rules inutil/danger/logic.ts(aggregateSizeWarnings,expectedBodyLength);cleanBody()strips HTML comments before measuring length so template scaffolding cannot inflate the count;util/danger/README.mdupdated to describe the new rules;.gitignoreextended with.coverage,.coverage.*, andhtmlcov/.Testing
util/danger/logic.test.tsadds unit tests foraggregateSizeWarnings,expectedBodyLength, the body-length cascade (empty / short-for-size / well-matched),cleanBody()HTML-comment stripping, and an end-to-end case throughevaluateDangerexercising a large multi-file PR shape.Repo checksjob already runsnpm testunderutil/danger/and executes the dangerfile on every PR, so the new rules and their tests stay covered on every future build.Documentation
util/danger/README.mdupdated to describe the two new rules and to point at the new PR template. No user-facing documentation changes — these are repository-infrastructure improvements.