windows.cfg: Add missing documentation and returnValue types#1125
Merged
versat merged 1 commit intoMar 19, 2018
Conversation
Additionally a few minor issues were fixed.
Collaborator
|
Can you please review this: 3af7aef it is the changed auto-generated test files. I should auto-generate tests for returnValue also. |
Collaborator
Author
|
I mainly added types for returnValue but did not specify the values itself. I guess this is why no tests for returnValue were generated? |
Collaborator
|
Do you have some suggestion how |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally a few minor issues are fixed.