Skip to content

Platforms: Add arm32 and arm64 platform files#1128

Merged
versat merged 1 commit into
cppcheck-opensource:masterfrom
versat:platform_files
Mar 21, 2018
Merged

Platforms: Add arm32 and arm64 platform files#1128
versat merged 1 commit into
cppcheck-opensource:masterfrom
versat:platform_files

Conversation

@versat
Copy link
Copy Markdown
Collaborator

@versat versat commented Mar 20, 2018

The default is "unsigned" so i have choosen it for the platformfiles.
This can be changed via a compiler option, but i am not sure if it makes
sense to add all the platform files with "signed" also.
Since the size of wchar_t depends on the compiler i added both possible
variants respectively.
Sizes of data types can be checked here for example:
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.den0024a/ch08s02.html

The default is "unsigned" so i have choosen it for the platformfiles.
This can be changed via a compiler option, but i am not sure if it makes
sense to add all the platform files with "signed" also.
Since the size of wchar_t depends on the compiler i added both possible
variants respectively.
Sizes of data types can be checked here for example:
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.den0024a/ch08s02.html
@danmar
Copy link
Copy Markdown
Collaborator

danmar commented Mar 20, 2018

nice! feel free to apply this.

@amai2012
Copy link
Copy Markdown
Collaborator

sizeof wchar_t is compiler dependent? Just an idea: Would it be helpful to name them like arm32_gcc instead?

@versat
Copy link
Copy Markdown
Collaborator Author

versat commented Mar 20, 2018

It is not only compiler dependent but also compiler option dependent. I missed to write that. The armcc for example sets the size of wchar_t automatically to 4 if a Linux configuration is given via command line and the size can also be set via command line flags to 2 and 4 manually, the default is 2. So this is not so easy to name it more elegant i guess 😀

@versat versat merged commit 22fa566 into cppcheck-opensource:master Mar 21, 2018
@versat versat deleted the platform_files branch March 21, 2018 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants