Skip to content

Fix Fix FP when using non-const members and also check return type of function for uniqueness#1283

Merged
danmar merged 1 commit intocppcheck-opensource:masterfrom
pfultz2:fp-duplicate-assign-return
Jun 9, 2018
Merged

Fix Fix FP when using non-const members and also check return type of function for uniqueness#1283
danmar merged 1 commit intocppcheck-opensource:masterfrom
pfultz2:fp-duplicate-assign-return

Conversation

@pfultz2
Copy link
Copy Markdown
Contributor

@pfultz2 pfultz2 commented Jun 8, 2018

This should fix issue 8613:

class PortWindow
{
public:
  ~PortWindow();
  uint16_t newPort();
};

class CommandHandler
{
public:
  void f();
  PortWindow& port_window_;
};

void CommandHandler::f()
{
      uint16_t port1 = port_window_.newPort();
      uint16_t port2 = port_window_.newPort();
      if(!port1 || !port2) {
      }
}

@danmar danmar merged commit 8d53bcf into cppcheck-opensource:master Jun 9, 2018
@pfultz2 pfultz2 deleted the fp-duplicate-assign-return branch May 19, 2019 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants