Skip to content

False positive #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghewgill wants to merge 2 commits into from
Closed

False positive #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4881caf
test for conditional operator and array index bounds
ghewgill Feb 8, 2011
060b0ac
false positive on array index when using a specific printf format
ghewgill Feb 8, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions test/testbufferoverrun.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ class TestBufferOverrun : public TestFixture
TEST_CASE(array_index_for_break); // FP: for,break
TEST_CASE(array_index_for); // FN: for,if
TEST_CASE(array_index_for_neq); // #2211: Using != in condition
TEST_CASE(array_index_for_printf);

TEST_CASE(buffer_overrun_1);
TEST_CASE(buffer_overrun_2);
Expand Down Expand Up @@ -1366,6 +1367,15 @@ class TestBufferOverrun : public TestFixture
" }\n"
"}\n");
ASSERT_EQUALS("", errout.str());

// check for conditional operator
check("void f() {\n"
" int a[10];\n"
" for (int i = 0; i < 10; i++) {\n"
" i == 0 ? 0 : a[i-1];\n"
" }\n"
"}");
ASSERT_EQUALS("", errout.str());
}

void array_index_for_neq()
Expand All @@ -1380,6 +1390,16 @@ class TestBufferOverrun : public TestFixture
ASSERT_EQUALS("[test.cpp:4]: (error) Buffer access out-of-bounds: a\n", errout.str());
}

void array_index_for_printf()
{
check("typedef char Str[10];\n"
"void f() {\n"
" Str s;\n"
" printf(\"%.*s %.*s\\n\", sizeof(Str), s, sizeof(Str), s);\n"
"}");
ASSERT_EQUALS("", errout.str());
}

void buffer_overrun_1()
{
check("void f()\n"
Expand Down