Add null pointer check to fix SEGFAULT#1499
Merged
danmar merged 3 commits intoDec 2, 2018
Merged
Conversation
Collaborator
|
Thanks! A test case would be nice! |
Collaborator
|
yes the fix looks ok but a test case would be nice. |
Contributor
Author
|
@orbitcowboy @danmar Ok, I will do it in the near future |
Contributor
Author
|
@danmar @orbitcowboy I've added the test case (with TODO), but I'll continue research of this problem to remove TODO from the test case. |
Collaborator
|
ok thanks! I applied these changes. Feel free to open a new PR that fix the TODO |
Collaborator
|
For your information I plan to release Cppcheck on december 8th.. so I will not allow improvements much longer.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have got the following SEGFAULT:
I this PR I'm proposing the fix of this problem.