Skip to content

donate-cpu-server.py: Limit number of functions shown in checkLibrary…#1641

Merged
versat merged 1 commit intocppcheck-opensource:masterfrom
versat:donate_cpu_server_limit_checklibrary_functions
Feb 5, 2019
Merged

donate-cpu-server.py: Limit number of functions shown in checkLibrary…#1641
versat merged 1 commit intocppcheck-opensource:masterfrom
versat:donate_cpu_server_limit_checklibrary_functions

Conversation

@versat
Copy link
Copy Markdown
Collaborator

@versat versat commented Feb 4, 2019

… reports

The checkLibraryFunction report is currently about 15 MB in size, lists more than 140000 functions and takes a long time to be generated.
Limiting the functions that are shown should save bandwidth, time and other resources on the server (and client that downloads the report).
Tested locally.

… reports

The checkLibraryFunction report is currently about 15 MB in size, lists more than 140000 functions and takes a long time to be generated.
Limiting the functions that are shown should save bandwidth, time and other resources on the server (and client that downloads the report).
Tested locally.
@versat versat force-pushed the donate_cpu_server_limit_checklibrary_functions branch from b3e24f8 to 1d0510f Compare February 4, 2019 15:02
@amai2012 amai2012 requested a review from danmar February 4, 2019 19:33
@amai2012
Copy link
Copy Markdown
Collaborator

amai2012 commented Feb 4, 2019

Sounds reasonable

@danmar
Copy link
Copy Markdown
Collaborator

danmar commented Feb 5, 2019

feel free to merge this

@versat versat merged commit 92d492e into cppcheck-opensource:master Feb 5, 2019
@versat versat deleted the donate_cpu_server_limit_checklibrary_functions branch February 5, 2019 09:39
@elfring
Copy link
Copy Markdown
Contributor

elfring commented Feb 5, 2019

  • How do you think about to adjust the presentation of source code analysis results any more?
  • Will the mentioned data amount trigger the reuse of advanced report tools?

@versat
Copy link
Copy Markdown
Collaborator Author

versat commented Feb 5, 2019

  • How do you think about to adjust the presentation of source code analysis results any more?

Hmm, there are always better ways to present the results i guess. Do you have any concrete suggestions or are you missing specific things?

  • Will the mentioned data amount trigger the reuse of advanced report tools?

I do not get this point. Could you explain more detailed what you mean?

@elfring
Copy link
Copy Markdown
Contributor

elfring commented Feb 5, 2019

I can contribute further suggestions and ideas for affected areas.
I am unsure on how they will fit to your software development interests and capacity.

@versat
Copy link
Copy Markdown
Collaborator Author

versat commented Feb 5, 2019

I can contribute further suggestions and ideas for affected areas.
I am unsure on how they will fit to your software development interests and capacity.

IMHO it would be great to read about ideas, suggestions and constructive criticism in the forum. There we could discuss what and how it makes sense to implement it.

@elfring
Copy link
Copy Markdown
Contributor

elfring commented Feb 5, 2019

Would you like to continue the clarification also on a topic like “Improving the presentation of source code analysis results”?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants