Skip to content

Fixx issue 9163: FP returnDanglingLifetime - returning std::string::find#1912

Merged
danmar merged 2 commits into
cppcheck-opensource:masterfrom
pfultz2:fp-9163
Jun 24, 2019
Merged

Fixx issue 9163: FP returnDanglingLifetime - returning std::string::find#1912
danmar merged 2 commits into
cppcheck-opensource:masterfrom
pfultz2:fp-9163

Conversation

@pfultz2
Copy link
Copy Markdown
Contributor

@pfultz2 pfultz2 commented Jun 21, 2019

No description provided.

@amai2012
Copy link
Copy Markdown
Collaborator

I didn't try to verify the fix explicitly, but given that there are different types of 'find' methods I checked for similar tests (to avoid false negative regressions) but could find only the single new one.

@danmar danmar merged commit 66e0f06 into cppcheck-opensource:master Jun 24, 2019
@amai2012
Copy link
Copy Markdown
Collaborator

At least some testing with std::set::find() was still successful...

@pfultz2 pfultz2 deleted the fp-9163 branch July 24, 2019 04:02
jubnzv pushed a commit to jubnzv/cppcheck that referenced this pull request Nov 13, 2019
…ind (cppcheck-opensource#1912)

* Fixx issue 9163: FP returnDanglingLifetime - returning std::string::find

* Use simpleMatch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants