Skip to content

misra.py: Add standard library identifiers#2524

Merged
orbitcowboy merged 2 commits intocppcheck-opensource:masterfrom
jubnzv:misra-std-lib
Feb 11, 2020
Merged

misra.py: Add standard library identifiers#2524
orbitcowboy merged 2 commits intocppcheck-opensource:masterfrom
jubnzv:misra-std-lib

Conversation

@jubnzv
Copy link
Copy Markdown
Contributor

@jubnzv jubnzv commented Feb 5, 2020

Add identifiers from C90 and C99 standards which are required to add additional analysis for some MISRA rules.

This commit fix false negatives for rule 21.1 and close Trac9603.

This is required to add additional analysis for some MISRA rules.

This commit improve R21.1 check and close trac ticket 9603.
@jubnzv jubnzv requested a review from orbitcowboy February 5, 2020 17:11
@jubnzv
Copy link
Copy Markdown
Contributor Author

jubnzv commented Feb 5, 2020

I'm not sure why I've added these lines before. It seems that rule 21.1 cases should work only with preprocessor directives.

Copy link
Copy Markdown
Collaborator

@orbitcowboy orbitcowboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@orbitcowboy
Copy link
Copy Markdown
Collaborator

I'm not sure why I've added these lines before. It seems that rule 21.1 cases should work only with preprocessor directives.

The standard only mentions the preprocessor in rule 21.1.

@orbitcowboy orbitcowboy self-requested a review February 6, 2020 12:35
@jubnzv
Copy link
Copy Markdown
Contributor Author

jubnzv commented Feb 11, 2020

@danmar @orbitcowboy
I resolved the conflicts, it could be merged now.

@orbitcowboy orbitcowboy merged commit 583d5e5 into cppcheck-opensource:master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants