Skip to content

Fixes to auto_ptr assignment false positive #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmar merged 2 commits into from
Jul 20, 2011
Merged

Fixes to auto_ptr assignment false positive #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c983608
Test false auto_ptr positive.
bwy Jul 20, 2011
e6d8f3f
Fix tested auto_ptr false positive.
bwy Jul 20, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/checkstl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1150,7 +1150,10 @@ void CheckStl::checkAutoPointer()
autoPointerArrayError(tok2->next());
}
}
autoPtrVarId.insert(tok2->next()->varId());
if (tok2->next()->varId())
{
autoPtrVarId.insert(tok2->next()->varId());
}
break;
}
tok2 = tok2->next();
Expand Down
6 changes: 6 additions & 0 deletions test/teststl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1376,6 +1376,12 @@ class TestStl : public TestFixture
"}\n");
ASSERT_EQUALS("[test.cpp:6]: (style) Copy 'auto_ptr' pointer to another do not create two equal objects since one has lost its ownership of the pointer.\n", errout.str());

check("std::auto_ptr<A> function();\n"
"int quit;"
"void f() { quit = true; }\n"
);
ASSERT_EQUALS("", errout.str());

// ticket #748
check("void f() \n"
"{\n"
Expand Down