fix #10068 (typedef not replaced when namespace is involved)

[IOBYTE]

No description provided.

[firewave]

Thanks a lot. The additional findings are expected - there is one missing though which appears with the conversion to using in #3007.

#include <memory>
#include <vector>

namespace clangimport {
	class AstNode;
	typedef std::shared_ptr<AstNode> AstNodePtr;
	//using AstNodePtr = std::shared_ptr<AstNode>;

	class AstNode {
	public:
		AstNode()
		{}
	private:
		void createScope(const std::vector<AstNodePtr> &children);
	};
}

void clangimport::AstNode::createScope(const std::vector<AstNodePtr> & children2)
{
}

typedef

##file /mnt/s/clion/example_lite_2/test.cpp
4: namespace clangimport {
5: class AstNode ;
6:
7:
8:
9: class AstNode {
10: public:
11: AstNode ( )
12: { }
13: private:
14: void createScope ( const std :: vector < std :: shared_ptr < AstNode > > & children@var1 ) ;
15: } ;
16: }
17:
18: void clangimport :: AstNode :: createScope ( const std :: vector < AstNodePtr > & children2@var2 )
19: {
20: }



##Value flow

/mnt/s/clion/example_lite_2/test.cpp:18:28: debug: Executable scope 'createScope' with unknown function. [symbolDatabaseWarning]
void clangimport::AstNode::createScope(const std::vector<AstNodePtr> & children2)
                           ^

using

4: namespace clangimport {
5: class AstNode ;
6:
7:
8:
9: class AstNode {
10: public:
11: AstNode ( )
12: { }
13: private:
14: void createScope ( const std :: vector < std :: shared_ptr < AstNode > > & children@var1 ) ;
15: } ;
16: }
17:
18: void clangimport :: AstNode :: createScope ( const std :: vector < std :: shared_ptr < AstNode > > & children2@var2 )
19: {
20: }



##Value flow

/mnt/s/clion/example_lite_2/test.cpp:18:72: style:inconclusive: Function 'createScope' argument 1 names different: declaration 'children' definition 'children2'. [funcArgNamesDifferent]
void clangimport::AstNode::createScope(const std::vector<AstNodePtr> & children2)
                                                                       ^
/mnt/s/clion/example_lite_2/test.cpp:14:51: note: Function 'createScope' argument 1 names different: declaration 'children' definition 'children2'.
  void createScope(const std::vector<AstNodePtr> &children);
                                                  ^
/mnt/s/clion/example_lite_2/test.cpp:18:72: note: Function 'createScope' argument 1 names different: declaration 'children' definition 'children2'.
void clangimport::AstNode::createScope(const std::vector<AstNodePtr> & children2)
                                                                       ^

Fixing that will probably help with https://trac.cppcheck.net/ticket/10061 and #2973.

[danmar]

I think that the self check warnings are fixed upstream.. can you try rebasing?

[danmar]

I recommend git rebase instead of git merge. Your changes should be applied on top of latest upstream main.

git reset --hard e5cbbb1
git rebase main
git push -f

[danmar]

I recommend git rebase instead of git merge. Your changes should be applied on top of latest upstream main.

ah sorry.. you work on your "main" branch. No harm done..

I suggest (https://medium.com/@topspinj/how-to-git-rebase-into-a-forked-repo-c9f05e821c8a):

git fetch upstream
git rebase upstream/main

[danmar]

👍 for using isFunctionHead