Skip to content

misra.py: Fix crashes on obsolete GCC syntax for struct initialization #3175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmar merged 2 commits into from
Mar 20, 2021
Merged

misra.py: Fix crashes on obsolete GCC syntax for struct initialization #3175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
427ad4e
misra.py: Fix crashes on obsolete GCC syntax for struct initialization
jubnzv Mar 20, 2021
91ad104
Added expected violations
jubnzv Mar 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions addons/misra_9.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@ def getChildByName(self, name):
def getNextValueElement(self, root):
current = self
while current != root:
if not current.parent:
return None
# Get next index of parent
i = current.parent.children.index(current) + 1
# Next index of parent exists
Expand Down
3 changes: 3 additions & 0 deletions addons/test/misra/misra-test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,9 @@ void misra_9_struct_initializers() {
dummy_struct dsd[2][2] = { 1, 2, 3, 4 }; // 9.2
dummy_struct dse[3] = { {1,2}, {3,4}, [1] = {5,6} }; // 9.3 9.4
dummy_struct dsd[] = { [0] = 1 }; // 9.5

// Obsolete initialization syntax for GCC
struct1 os1 = { i1: 1, i2: 2 }; // 10.4 13.4
}

void misra_9_broken_initializers() {
Expand Down