scan GUI sources with clang-tidy in CI#3233
Merged
Merged
Conversation
danmar
reviewed
Oct 11, 2021
Collaborator
danmar
left a comment
danmar
left a comment
There was a problem hiding this comment.
I don't understand why you remove lots of code in various files. For instance CI-cygwin.yml
Collaborator
Author
So it builds only the job I modified and I save time and CI resources while developing it. Also this is still a draft :) |
Collaborator
OK sorry. |
firewave
force-pushed
the
tidy-ui
branch
2 times, most recently
from
3377d1e to
820b653
Compare
Collaborator
Author
|
@danmar This is finally ready for review. |
danmar
approved these changes
Oct 30, 2021
Collaborator
danmar
left a comment
danmar
left a comment
There was a problem hiding this comment.
lgtm but I don't know much about cmake.
Collaborator
Author
The CMake stuff is just the addition of targets to generate the files Qt generates without compiling anything since it is not necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.