Skip to content

Fix in MISRA rule 6.1 check #3458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmar merged 3 commits into from
Sep 22, 2021
Merged

Fix in MISRA rule 6.1 check #3458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8fb325
Improve MISRA 6.1 rule
danimartin82 Sep 19, 2021
1c7962d
Add test for MISRA 6.1 rule
danimartin82 Sep 20, 2021
c9e1231
Update misra.py
danimartin82 Sep 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions addons/misra.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1686,7 +1686,7 @@ def misra_6_1(self, data):
continue

if data.standards.c == 'c89':
if token.valueType.type != 'int':
if token.valueType.type != 'int' and not isUnsignedType(token.variable.typeStartToken.str):
self.reportError(token, 6, 1)
elif data.standards.c == 'c99':
if token.valueType.type == 'bool':
Expand All @@ -1695,7 +1695,7 @@ def misra_6_1(self, data):
isExplicitlySignedOrUnsigned = False
typeToken = token.variable.typeStartToken
while typeToken:
if typeToken.isUnsigned or typeToken.isSigned:
if typeToken.isUnsigned or typeToken.isSigned or isUnsignedType(typeToken.str):
isExplicitlySignedOrUnsigned = True
break

Expand Down
1 change: 1 addition & 0 deletions addons/test/misra/misra-test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,7 @@ struct struct_with_bitfields
signed long f:2; // 6.1 - signed long not compliant
unsigned int g:1; // Compliant
signed int h:1; // 6.2 - signed int with size 1 is not compliant
uint16_t i:1; // Compliant
};

static void misra6_1_fn(void) {
Expand Down