Implement support for passing multiple file filters#3479
Merged
danmar merged 5 commits intoNov 23, 2021
Conversation
danmar
reviewed
Oct 4, 2021
Collaborator
danmar
left a comment
danmar
left a comment
There was a problem hiding this comment.
thanks! looks pretty good.
Collaborator
|
as far as I see the ci failure is caused by formatting. |
Contributor
Author
|
Okay let's see if I got them fixed :-) |
Contributor
Author
|
There was one whitespace too much it seems ... fixed it now. uncrustify -c .uncrustify.cfg -l CPP --check /.cpp /.h shows me some more errors on files I didn't touch though. What should I do? Also has uncrustify something like a "fix all automatically" or at least show the errors directly in the command line? |
Contributor
Author
|
@danmar Anything blocking this or missing? |
danmar
approved these changes
Oct 15, 2021
Collaborator
danmar
left a comment
danmar
left a comment
There was a problem hiding this comment.
just a small nit. please remove the redundant include.
Collaborator
|
Thanks! If CI will be happy I believe we can merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in https://sourceforge.net/p/cppcheck/discussion/general/thread/43471c7ea1/, I added support for passing multiple file filters.