fixed some compiler warnings

[firewave]

No description provided.

[firewave]

I wonder if these are things Cppcheck should have detected as well.

[danmar]

Yes possibly. In general.. if a new check is needed and the compiler already detect the issue well then I think the ROI to implement it in Cppcheck also is not great.
We have a check for unused variables so that should have warned about the token variable. I have the feeling that our check for unused variables will warn for many cases that compilers do not so it makes sense to keep this check in Cppcheck.

[firewave]

Yes possibly. In general.. if a new check is needed and the compiler already detect the issue well then I think the ROI to implement it in Cppcheck also is not great. We have a check for unused variables so that should have warned about the token variable. I have the feeling that our check for unused variables will warn for many cases that compilers do not so it makes sense to keep this check in Cppcheck.

I was thinking about flagging tickets about checks/cases which are not detected by other tools so you could filter for them.

[danmar]

I was thinking about flagging tickets about checks/cases which are not detected by other tools so you could filter for them.

that sounds good to me. those would be extra valuable.