Fixed #10432 (Only the first default argument was copied from the forward declaration)#3530
Merged
Merged
Conversation
danmar
approved these changes
Oct 28, 2021
Collaborator
danmar
left a comment
danmar
left a comment
There was a problem hiding this comment.
if ci is happy I think we should merge this.
Collaborator
|
The workflows still need approval. |
Collaborator
|
This has been approved for quite some time now... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://trac.cppcheck.net/ticket/10432
I'm not sure why the break was introduced in the first place. Please let me know if you see that I'm missing something here. But to me it looks like it just copies the default values for the first parameter which has a default. If multiple parameters have a default value, the default values of the remaining parameters are missing and it trips up later templatesimplifier steps.