donate_cpu_lib.py: fix callstack capture, fix dependency check

[guillaume-uH57J9]

check_requirements: verify that module psutil is available.
scan_package: collect crash callstack regardless of cppcheck_path and cppcheck version

[guillaume-uH57J9]

The issue was reported by @firewave in a comment at a3560aa

[firewave]

I like that

[guillaume-uH57J9]

Okay.
I removed this test because I thought it made sense to capture for all versions; it would make diff output easier to interpret.
Since it's needed I brought it back as an explicit parameter.

[firewave]

Okay. I removed this test because I thought it made sense to capture for all versions; it would make diff output easier to interpret. Since it's needed I brought it back as an explicit parameter.

We only store this information for head since we do rolling releases from main so we don't need that information for previous releases.

The parameter is better implementation as it removes some logic from the function and makes it clearer what it actually does. 🥳

[firewave]

Gave it a spin and it works again - see http://cppcheck1.osuosl.org:8000/angband

Thanks for the fast reply.