release-windows.yml: use windows-2022#3939
Merged
danmar merged 2 commits intocppcheck-opensource:mainfrom May 13, 2022
Merged
Conversation
firewave
changed the title
firewave
force-pushed
the
win2022-release
branch
6 times, most recently
from
cf3818f to
89df7b7
Compare
Collaborator
|
sounds good. |
firewave
force-pushed
the
win2022-release
branch
from
20860e3 to
c9be88b
Compare
firewave
changed the title
firewave
force-pushed
the
win2022-release
branch
2 times, most recently
from
d0f4ba8 to
c4e4243
Compare
Collaborator
Author
|
@danmar This is ready for review. Here's the result of a test build with the changes environment: https://github.com/danmar/cppcheck/runs/6402075893?check_suite_focus=true. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have been using
windows-2022in the CI for a while without any issues. I have been using it locally as the Windows compiler of choice as well.Since we might switch to Qt6 is the next release it would be good to do the compiler switch first so we don't have too many major version bumps in a single release.
The updated MSM location is documented at https://github.com/MicrosoftDocs/cpp-docs/blob/main/docs/windows/redistributing-visual-cpp-files.md#locate-the-redistributable-files.