Fix #10526 FP: negativeIndex if function call is made after index check#4052
Merged
orbitcowboy merged 4 commits intocppcheck-opensource:mainfrom Apr 27, 2022
Merged
Conversation
pfultz2
reviewed
Apr 27, 2022
| // Assume library function doesn't modify user-global variables | ||
| return Action::None; | ||
| // Function cast does not modify global variables | ||
| } else if (Token::simpleMatch(tok->astParent(), ".") && tok->astParent()->astOperand1() && tok->astParent()->astOperand1()->variable() && |
Contributor
There was a problem hiding this comment.
We shouldn't do tok->astParent()->astOperand1()->variable() as containers can be arbitrary expressions. Can you just do astIsContainer(tok->astParent()->astOperand1())?
chrchr-github
force-pushed
the
chr_Fix10526
branch
from
3b58e6a to
6153c95
Compare
pfultz2
approved these changes
Apr 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.