Skip to content

Remove severity 'experimental' from checkComparisonOfBoolWithBool()#4097

Merged
orbitcowboy merged 3 commits intocppcheck-opensource:mainfrom
chrchr-github:chr_Fix2617
May 10, 2022
Merged

Remove severity 'experimental' from checkComparisonOfBoolWithBool()#4097
orbitcowboy merged 3 commits intocppcheck-opensource:mainfrom
chrchr-github:chr_Fix2617

Conversation

@chrchr-github
Copy link
Copy Markdown
Collaborator

No description provided.

@orbitcowboy orbitcowboy merged commit e2bb77f into cppcheck-opensource:main May 10, 2022
@firewave
Copy link
Copy Markdown
Collaborator

firewave commented May 13, 2022

@chrchr-github @danmar @pfultz2 @orbitcowboy
There's currently no way to enable experimental check swith a binary at all making it essentially dead code.

So we should add an --experimental flag, move these checks into inconclusive or completely remove them completely.

There's currently only two places which are using this.

Also there's some code we put behind if (false) - so if we keep the certainty in question we should probably leverage it for that code so it can at least be run in tests. This would also get rid of the "unreferenced" code warnings in Visual Studio.

For full support of experimental we would also need to make it like inconclusive adding the information to the finding and the output so these are flagged as such which would complicate things. So adding the full support does not seem feasible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants