Fix #9997 False negative: variable is not used#4104
Merged
danmar merged 4 commits intocppcheck-opensource:mainfrom Jun 7, 2022
Merged
Fix #9997 False negative: variable is not used#4104danmar merged 4 commits intocppcheck-opensource:mainfrom
danmar merged 4 commits intocppcheck-opensource:mainfrom
Conversation
pfultz2
reviewed
May 12, 2022
| ++indentlevel; | ||
| continue; | ||
| } | ||
| tok2 = cond->astParent()->previous(); |
Contributor
There was a problem hiding this comment.
Why is this changed? If the condition is false we should be skipping the entire block.
Contributor
There was a problem hiding this comment.
Ah wait, I see, it's a dead store. Thats a bug. I think we need to continue here and not break. I think we can fix this in a later PR.
Collaborator
Author
|
Also ran into this: https://trac.cppcheck.net/ticket/11063 |
Collaborator
Author
|
Is this ready to be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.