Skip to content

separated process execution code into ProcessExecutor#4249

Merged
danmar merged 3 commits intocppcheck-opensource:mainfrom
firewave:executor-2
Jul 8, 2022
Merged

separated process execution code into ProcessExecutor#4249
danmar merged 3 commits intocppcheck-opensource:mainfrom
firewave:executor-2

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

@firewave firewave commented Jul 6, 2022

had this sitting around

  • refactoring only
  • clearly separates the process and thread execution code
  • either code is no longer behind a preprocessor define and is visible to more compilers and the various static code analysis (including ours)
  • would allow for run-time switching with future changes
  • existing tests were just duplicated and should not be redundant
  • tests need to be extended to account for differences in implementation (cannot correctly remember what they were but it is at least related to suppression handling)
  • easier to define an interface which will leverage the proposed simplifications by @PKEuS
  • did some additional iwyu cleanups since I had to run it anyways

@firewave firewave force-pushed the executor-2 branch 5 times, most recently from 3fd7acb to 885bf70 Compare July 6, 2022 22:01
@danmar danmar merged commit b51aea5 into cppcheck-opensource:main Jul 8, 2022
@firewave firewave deleted the executor-2 branch July 8, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants