fixed some modernize-use-emplace false negatives and some bugprone-assignment-in-if-condition warnings#4311
Merged
danmar merged 3 commits intocppcheck-opensource:mainfrom Jul 28, 2022
Conversation
firewave
commented
Jul 26, 2022
| if (type) | ||
| return type; | ||
| else if ((scope1 = scope->findRecordInBase(tok->str()))) { | ||
| else if (const Scope *scope1 = scope->findRecordInBase(tok->str())) { |
Collaborator
Author
There was a problem hiding this comment.
This is probably something which would fall under "scope reduction". I will file a ticket about this.
Collaborator
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are not interested in
bugprone-assignment-in-if-conditionas it's something we use intentionally. I did fix two cases where it was unnecessary though.We also encountered two false positives with it. The first one is filed as llvm/llvm-project#56729.
The
modernize-use-emplacefalse negatives already have upstream tickets:llvm/llvm-project#56721
llvm/llvm-project#55870
llvm/llvm-project#55869
llvm/llvm-project#55856