Skip to content

#11233 FP: knownConditionTrueFalse (wrong message text)#4330

Merged
orbitcowboy merged 4 commits intocppcheck-opensource:mainfrom
chrchr-github:chr_Fix11233
Aug 2, 2022
Merged

#11233 FP: knownConditionTrueFalse (wrong message text)#4330
orbitcowboy merged 4 commits intocppcheck-opensource:mainfrom
chrchr-github:chr_Fix11233

Conversation

@chrchr-github
Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread lib/astutils.cpp
Token::Match(tok->tokAt(-3), "this . %name% (")) {
if (tok->previous()->function()) {
return (!tok->previous()->function()->isConst());
return (!tok->previous()->function()->isConst() && !tok->previous()->function()->isStatic());
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not instrumental to this fix, but seemed incorrect.

@firewave
Copy link
Copy Markdown
Collaborator

firewave commented Aug 2, 2022

The build has been fixed - please rebase.

@orbitcowboy orbitcowboy merged commit 92d569a into cppcheck-opensource:main Aug 2, 2022
@chrchr-github chrchr-github deleted the chr_Fix11233 branch October 22, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants