Skip to content

fixed #11249 (potential hang with -j and --showtime= when using threads) - synchronized access to TimerResults::mResults / added TSAN to CI#4355

Merged
danmar merged 8 commits intocppcheck-opensource:mainfrom
firewave:deadlock-2
Aug 23, 2022
Merged

fixed #11249 (potential hang with -j and --showtime= when using threads) - synchronized access to TimerResults::mResults / added TSAN to CI#4355
danmar merged 8 commits intocppcheck-opensource:mainfrom
firewave:deadlock-2

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

No description provided.

@firewave firewave marked this pull request as ready for review August 12, 2022 14:05
@firewave
Copy link
Copy Markdown
Collaborator Author

FYI I did the incremental commits with pre-comitting the test in f3ae5c0 to verify that TSAN is actually detecting the issue and failing the test before the fix is applied - which it did.

It was also detected in the selfcheck but that is just too slow to be enabled. I will re-visit that at a later date.

@firewave
Copy link
Copy Markdown
Collaborator Author

@danmar
Anything preventing this from being merged?

@danmar danmar merged commit 467648b into cppcheck-opensource:main Aug 23, 2022
@firewave firewave deleted the deadlock-2 branch August 23, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants