actually perform system tinyxml2 build on macos / fixed system tinyxml2 include#4445
Merged
Merged
Conversation
firewave
force-pushed
the
tinyxml2-ext
branch
from
db22fa0 to
e151663
Compare
firewave
force-pushed
the
tinyxml2-ext
branch
from
e151663 to
3f36318
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We did not specify the tinyxml2 include directory in all cases when using the system library. That was working fine since it is placed directly in a common system include directory on Linux. When installing via brew on macos it is not and thus the build failed.